Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent subscription execution without websocket #1165

Merged
merged 4 commits into from
Feb 21, 2024

Conversation

rafalp
Copy link
Collaborator

@rafalp rafalp commented Feb 21, 2024

Fixes #1164

@rafalp rafalp added this to the Next release milestone Feb 21, 2024
@rafalp rafalp self-assigned this Feb 21, 2024
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c5fa431) 97.87% compared to head (fae7d68) 97.88%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1165   +/-   ##
=======================================
  Coverage   97.87%   97.88%           
=======================================
  Files         109      109           
  Lines        8059     8094   +35     
=======================================
+ Hits         7888     7923   +35     
  Misses        171      171           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rafalp rafalp merged commit f50f140 into main Feb 21, 2024
22 checks passed
@rafalp rafalp deleted the fix-1164-prevent-subscriptions-in-graphql-exec branch February 21, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ariadne graphql and graphql_sync will attempt to execute subscription operations
1 participant