Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Apollo Explorer: allow setting includeCookies #1172

Merged
merged 4 commits into from
Apr 9, 2024

Conversation

antoni-szych-rtbhouse
Copy link
Contributor

allow setting includeCookies parameter of embedded Apollo Explorer

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.86%. Comparing base (e3d8e6b) to head (edb6dfa).
Report is 5 commits behind head on main.

❗ Current head edb6dfa differs from pull request most recent head d49175e. Consider uploading reports for the commit d49175e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1172      +/-   ##
==========================================
- Coverage   97.86%   97.86%   -0.01%     
==========================================
  Files         109      109              
  Lines        8153     8135      -18     
==========================================
- Hits         7979     7961      -18     
  Misses        174      174              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@antoni-szych-rtbhouse
Copy link
Contributor Author

@rafalp could you please take a look when you will have a moment? :)

@rafalp
Copy link
Collaborator

rafalp commented Apr 8, 2024

Looks ok, but can you provide a test?

@rafalp rafalp self-requested a review April 8, 2024 13:20
@rafalp rafalp added this to the Next release milestone Apr 8, 2024
@antoni-szych-rtbhouse
Copy link
Contributor Author

Looks ok, but can you provide a test?

done

@rafalp
Copy link
Collaborator

rafalp commented Apr 8, 2024

Sorry, this will also require a CHANGELOG entry, eg.:

Added include_cookies option to the ExplorerApollo.

@antoni-szych-rtbhouse
Copy link
Contributor Author

Sorry, this will also require a CHANGELOG entry, eg.:

Done.

@rafalp rafalp merged commit 7483a2d into mirumee:main Apr 9, 2024
20 checks passed
@Jozefiel
Copy link

Jozefiel commented Jul 2, 2024

When will be release of the package with that change? It's making me some problems to use it with oauth2-proxy.

@antoni-szych-rtbhouse antoni-szych-rtbhouse deleted the apollo-explorer-cookies branch July 3, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants