Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved tests into the passkeys package #49

Closed

Conversation

christian-thieme
Copy link

Necessary adjustments:

  • authentication tests should not use a view from the example project but the authentication backend
  • the authentication backend should not throw exceptions, all form validation must be done by the LoginForm class, if login fails the backend should simply return None, for configuration errors use logging
  • fixed a possible exception in delKey, improved the logic in delKey and toggleKey

Necessary adjustments:

- authentication tests should not use a view from the example project but the authentication backend
- the authentication backend should not throw exceptions, all form validation must be done by the LoginForm class, if login fails the backend should simply return None, for configuration errors use logging
- fixed a possible exception in delKey, improved the logic in delKey and toggleKey
@mkalioby
Copy link
Owner

This has been moved to #50 to be able to fixed the Github actions

@mkalioby mkalioby closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants