Skip to content

Commit

Permalink
feat: upgrade three.js to v172 (#14)
Browse files Browse the repository at this point in the history
  • Loading branch information
mlight-lee authored Jan 9, 2025
1 parent 3f9f0e9 commit 5a219ad
Show file tree
Hide file tree
Showing 4 changed files with 28 additions and 21 deletions.
6 changes: 3 additions & 3 deletions packages/three-viewcube-demo/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,12 @@
"lint": "pnpm eslint -c ../../.eslintrc.js --ext .ts,.js,.vue --quiet src/"
},
"devDependencies": {
"@types/three": "^0.166.0"
"@types/three": "^0.172.0"
},
"dependencies": {
"@mlightcad/three-viewcube": "^0.0.6",
"@mlightcad/three-viewcube": "^0.0.8",
"@tweenjs/tween.js": "^25.0.0",
"lil-gui": "^0.19.2",
"three": "^0.166.1"
"three": "^0.172.0"
}
}
1 change: 1 addition & 0 deletions packages/three-viewcube-demo/src/baseView.ts
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,7 @@ export class BaseViewer {

protected createSimpleCameraControls() {
const simpleCameraControls = new SimpleCameraControls(this.camera)
// @ts-expect-error No good way to fix this type error
simpleCameraControls.setControls(this.cameraControls)
return simpleCameraControls
}
Expand Down
6 changes: 3 additions & 3 deletions packages/three-viewcube/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"description": "A highly customizable standalone view cube addon for three.js",
"license": "MIT",
"private": false,
"version": "0.0.6",
"version": "0.0.8",
"author": "MLight Lee <[email protected]>",
"repository": {
"type": "git",
Expand Down Expand Up @@ -41,10 +41,10 @@
"lint": "pnpm eslint -c ../../.eslintrc.js --ext .ts,.js,.vue --quiet src/"
},
"devDependencies": {
"@types/three": "^0.166.0",
"@types/three": "^0.172.0",
"rollup-plugin-peer-deps-external": "^2.2.4"
},
"peerDependencies": {
"three": "^0.166.1"
"three": "^0.172.0"
}
}
36 changes: 21 additions & 15 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 5a219ad

Please sign in to comment.