Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed terraform s3 backend from dynamodb to s3 lockfile #175

Merged
merged 8 commits into from
Dec 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/actions/setup-python/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,14 @@ runs:
with:
# Install a specific version of uv.
version: "0.4.30"
- name: Get Terraform Version
id: tf_version
run: |
echo "value=$(cat .terraform-version)" >> $GITHUB_OUTPUT
shell: bash
- uses: hashicorp/setup-terraform@v3
with:
terraform_version: ${{ steps.env_name.outputs.value }}
- name: Set up Python
uses: actions/setup-python@v5
with:
Expand Down
1 change: 1 addition & 0 deletions .terraform-version
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
1.10.2
6 changes: 0 additions & 6 deletions .verified_terraform_versions

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ def get_provider_backend(self, provider: CloudProvider) -> dict:
"s3": {
"bucket": self.get_statefile_name(),
"key": "ultimate-mlops-stack",
"dynamodb_table": self.get_statefile_name(),
"use_lockfile": True,
"region": self.region,
"encrypt": True,
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ def configure_provider(self):
# "config": {
# "bucket": self.get_statefile_name(),
# "key": "ultimate-mlops-stack",
# "dynamodb_table": self.get_statefile_name(),
# "use_lockfile": True,
# "region": self.region,
# },
# }
Expand Down
2 changes: 1 addition & 1 deletion src/mlinfra/utils/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ def create_symlinks(source: str, destination: str) -> None:

def terraform_tested_version():
# TODO: read from a file and then populate this field
return "1.6.3"
return "1.10.2"


# def _verify_aws_cloud_credentials(self) -> None:
Expand Down
2 changes: 1 addition & 1 deletion uv.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading