Fix moving the Dragon in PnD expansion #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added another commit, fixes two more issues.
|
In the Princesses and Dragons expansion, there is a bug that arose from the lua refactoring that was done in this fork. Currently, upon drawing a dragon tile with the dragon on the board, the dragon movement sequence starts correctly. However, the dragon movement buttons throw script errors, because the functions tied to the buttons are inaccessible due to being `local`. Removing the `local` from the four functions fixes this issue and allows the dragon movement to proceed properly.
This is also present in the orignial version by DinnerBuffet. It appears that in one point in time, the depth of the tiles shrunk by about 0.06 units. The scripable play area zone was made to work with the original tile height, with the shrink there is a 0.06 unit gap right above the tiles, where small flat pieces (like sheep/wolf tokens that are 0.02 units deep) will fall into and not be tracked. Moving down the scripting zone to accomidate completely fixes HnS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Princesses and Dragons expansion, there is a bug that arose from the lua refactoring that was done in this fork.
Currently, upon drawing a dragon tile with the dragon on the board, the dragon movement sequence starts correctly.
However, the dragon movement buttons throw script errors, because the functions tied to the buttons are inaccessible due to being
local. Removing thelocalfrom the four functions fixes this issue and allows the dragon movement to proceed properly.After a code search, it seems that these are the only problematic buttons in the whole project.
By the way, thank you for continuing adding stuff to this project, I use this save file a lot to play with my friends. The quality of life stuff and additional statistics are really nice.