util/compression: consolidate implementations #5354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to some existing functions, use an un-exported package variable to register mappings. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Similar to some existing functions, use an un-exported package variable to register mappings. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
compression_clean
branch
from
1d4cf7f to
ceda214
Compare
tonistiigi
reviewed
Oct 1, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was part of some (unfinished) work to change compressions to use a "registration"; this would allow additional compressions to be added through separate packages, and register themselves, without them being part of the
util/compressionpackage itself (and because of this, being considered required dependencies).Similar to some existing functions, use an un-exported package variable to register mappings.
Similar to some existing functions, use an un-exported package variable to register mappings.