cache: add tracing to prune #5627
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/hack
jsternberg
force-pushed
the
prune-tracing
branch
from
603be55 to
9f8eaf2
Compare
Adds tracing to the cache manager prune operation. The attribute will show both explicit prunes from a user and background prunes initiated after solve requests are processed. Signed-off-by: Jonathan A. Sternberg <[email protected]>
jsternberg
force-pushed
the
prune-tracing
branch
from
9f8eaf2 to
573d6cb
Compare
tonistiigi
reviewed
Feb 6, 2025
| // | ||
| // This function isn't meant to be called in a tight loop. It is intended to be | ||
| // called on initialization and the tracer is supposed to be retained for future use. | ||
| func Tracer(tp trace.TracerProvider, options ...trace.TracerOption) trace.Tracer { |
There was a problem hiding this comment.
This should be called TracerForCurrentFrame or smth like that
| @@ -1009,6 +1026,9 @@ func (cm *cacheManager) createDiffRef(ctx context.Context, parents parentRefs, d | |||
| } | |||
|
|
|||
| func (cm *cacheManager) Prune(ctx context.Context, ch chan client.UsageInfo, opts ...client.PruneInfo) error { | |||
| ctx, span := cm.tracer.Start(ctx, "(*cacheManager).Prune") | |||
There was a problem hiding this comment.
The prunes coming from background GC should have a root span based on the GC function, not for individual prune calls for each rule. (Can even trace the reason for starting the GC).
For Prunes coming through grpc they should trace to the tracing context already in ctx.
So afaics these should use the tracing.StartSpan(ctx) like the rest of the tracers and control.gc() should have a way to inject root span to ctx before it calls into cm.Prune().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tracing to the cache manager prune operation. The attribute will show both explicit prunes from a user and background prunes initiated after solve requests are processed.
The prune code has also been refactored a bit to remove a recursive call to prune. It has now been unrolled and the functions have been renamed so
prunestands for the entire prune process andpruneOnceis a single cycle. Previously,prunewas a single cycle andpruneOncewould run the entire prune cycle with a set of options.This also disabled the delve component of the
hack/composescript. It appears to be broken at the moment.