Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit updated package-lock.json to fix ts build #722

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jacobcolyvan
Copy link

Description

Typescript builds have been down for around a month.
Looking at the most recent main build action run, it is due to packages missing from the package-lock.json:

2025-02-24T16:42:57.7883008Z npm error `npm ci` can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with `npm install` before continuing.
2025-02-24T16:42:57.7884581Z npm error
2025-02-24T16:42:57.7885173Z npm error Missing: [email protected] from lock file
2025-02-24T16:42:57.7885877Z npm error Missing: [email protected] from lock file
2025-02-24T16:42:57.7886716Z npm error Missing: @modelcontextprotocol/[email protected] from lock file
2025-02-24T16:42:57.7887617Z npm error Missing: @types/[email protected] from lock file
2025-02-24T16:42:57.7888418Z npm error Missing: [email protected] from lock file
2025-02-24T16:42:57.7889065Z npm error Invalid: lock file's [email protected] does not satisfy [email protected]
2025-02-24T16:42:57.7889663Z npm error Missing: @redis/[email protected] from lock file
2025-02-24T16:42:57.7890174Z npm error Missing: @redis/[email protected] from lock file
2025-02-24T16:42:57.7890629Z npm error Missing: @redis/[email protected] from lock file
2025-02-24T16:42:57.7891086Z npm error Missing: @redis/[email protected] from lock file
2025-02-24T16:42:57.7891548Z npm error Missing: @redis/[email protected] from lock file
2025-02-24T16:42:57.7892036Z npm error Missing: @redis/[email protected] from lock file
2025-02-24T16:42:57.7892536Z npm error Missing: [email protected] from lock file
2025-02-24T16:42:57.7892995Z npm error Missing: [email protected] from lock file
2025-02-24T16:42:57.7893417Z npm error Missing: [email protected] from lock file
2025-02-24T16:42:57.7893978Z npm error

This is likely due to PRs being merged without npm install being run in the root which results in package.json being out of sync with the lock file.

This PR just runs npm install to update the lock with the missing packages.

Motivation and Context

This is blocking recent updates to the servers being release on NPM and means updates are not getting pulled when people try to install these servers via npx.

How Has This Been Tested?

All GitHub actions are now passing.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Protocol Documentation
  • My changes follows MCP security best practices
  • I have updated the server's README accordingly
  • I have tested this with an LLM client
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have documented all environment variables and configuration options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant