-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace setuptools with hatchling, remove 'build' extra #2446
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2446 +/- ##
=========================================
+ Coverage 68.4% 76.3% +7.8%
=========================================
Files 294 293 -1
Lines 59390 60120 +730
=========================================
+ Hits 40652 45886 +5234
+ Misses 18738 14234 -4504 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pypi fragments tool looks nice. Seems like we could improve on the current https://github.com/modflowpy/flopy/blob/develop/docs/PyPI_release.md.
It is because |
@mwtoews any idea what the original motivation to use those options might have been? Looks mostly OK without them. The extended build fails now but that seems like the 3rd party 7zip action doesn't play nice with something that is now in the pixi env. |
I think 2220 solves it. |
This PR changes the build backend from setuptools to hatchling. See background in modflowpy/flopy#2446 Other minor changes is to remove an unused .flake8 configuration file and unused tool.setuptools_scm option.
This PR changes the build backend from setuptools to hatchling. See background in modflowpy/flopy#2446
This PR changes the build backend from setuptools to hatchling. See background in modflowpy/flopy#2446
* ci(release): update version to 1.2.11.dev0 * ci: fix schedule for windows (#193) * fix(requests): update available assets (#194) Add macarm.zip asset * chore: reformat Python code with line length = 88 (#198) Reformat the code with a maximum line length of 88 characters to better represent the code. See modflowpy/flopy#2362 for a related PR with rational and discussion. Also change some of Ruff's configuration: - Remove target-version, since it is automatically evaluated from pyproject.toml - Remove include so that Ruff will work globally in this repo * fix: cleanup _get_optlevel verbose param in pymake_base (#199) Co-authored-by: mjreno <[email protected]> * refactor: clean-up strings and Path related aspects, add a few Ruff rules (#200) Refactor a few semi-related aspects: - Revise strings and whitespace using a few methods with Ruff and manual edits - Revise a few aspects of pathlib.Path -- these changes are added here to shorten some string formatting, but remain consistent throughout the code base - Fix one more instance of removed verbose parameter in _get_optlevel(), similar to #199 - Apply Ruff pyupgrade (UP) rules - Apply Ruff section-underline-matches-section-length (D409) rule - Apply Ruff-specific rules (RUF) * build(deps): bump dawidd6/action-download-artifact from 6 to 7 (#201) * update for mf6.6.0 (#203) * fix fortran submodule evaluation * update sutra and mfusg_gsi versions. * update pixi version * ci: fix release code.md path (#205) * sync master and update version * refactor(makefile): changes to makefile generation to limit changes (#208) * ci: pin ubuntu-22.04 for now (#209) Workaround oneAPI incompatibility with ubuntu-24.04 * chore: replace setuptools with hatchling (#210) This PR changes the build backend from setuptools to hatchling. See background in modflowpy/flopy#2446 * build(deps): bump prefix-dev/setup-pixi from 0.8.1 to 0.8.2 (#211) Bumps [prefix-dev/setup-pixi](https://github.com/prefix-dev/setup-pixi) from 0.8.1 to 0.8.2. - [Release notes](https://github.com/prefix-dev/setup-pixi/releases) - [Commits](prefix-dev/setup-pixi@v0.8.1...v0.8.2) --- updated-dependencies: - dependency-name: prefix-dev/setup-pixi dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * update mf6 and zbud6 version (#212) * chore: fix typos and add codespell configuration (#213) * ci: update scheduled workflow (#214) * change ubuntu-latest to ubuntu-22.04 for intel-classic * Trigger notification --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: wpbonelli <[email protected]> Co-authored-by: Mike Taves <[email protected]> Co-authored-by: mjreno <[email protected]> Co-authored-by: mjreno <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* ci(release): update version to 1.2.11.dev0 * ci: fix schedule for windows (#193) * fix(requests): update available assets (#194) Add macarm.zip asset * chore: reformat Python code with line length = 88 (#198) Reformat the code with a maximum line length of 88 characters to better represent the code. See modflowpy/flopy#2362 for a related PR with rational and discussion. Also change some of Ruff's configuration: - Remove target-version, since it is automatically evaluated from pyproject.toml - Remove include so that Ruff will work globally in this repo * fix: cleanup _get_optlevel verbose param in pymake_base (#199) Co-authored-by: mjreno <[email protected]> * refactor: clean-up strings and Path related aspects, add a few Ruff rules (#200) Refactor a few semi-related aspects: - Revise strings and whitespace using a few methods with Ruff and manual edits - Revise a few aspects of pathlib.Path -- these changes are added here to shorten some string formatting, but remain consistent throughout the code base - Fix one more instance of removed verbose parameter in _get_optlevel(), similar to #199 - Apply Ruff pyupgrade (UP) rules - Apply Ruff section-underline-matches-section-length (D409) rule - Apply Ruff-specific rules (RUF) * build(deps): bump dawidd6/action-download-artifact from 6 to 7 (#201) * update for mf6.6.0 (#203) * fix fortran submodule evaluation * update sutra and mfusg_gsi versions. * update pixi version * ci: fix release code.md path (#205) * sync master and update version * refactor(makefile): changes to makefile generation to limit changes (#208) * ci: pin ubuntu-22.04 for now (#209) Workaround oneAPI incompatibility with ubuntu-24.04 * chore: replace setuptools with hatchling (#210) This PR changes the build backend from setuptools to hatchling. See background in modflowpy/flopy#2446 * build(deps): bump prefix-dev/setup-pixi from 0.8.1 to 0.8.2 (#211) Bumps [prefix-dev/setup-pixi](https://github.com/prefix-dev/setup-pixi) from 0.8.1 to 0.8.2. - [Release notes](https://github.com/prefix-dev/setup-pixi/releases) - [Commits](prefix-dev/setup-pixi@v0.8.1...v0.8.2) --- updated-dependencies: - dependency-name: prefix-dev/setup-pixi dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * update mf6 and zbud6 version (#212) * chore: fix typos and add codespell configuration (#213) * ci: update scheduled workflow (#214) * change ubuntu-latest to ubuntu-22.04 for intel-classic * Release v1.4.0 --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: wpbonelli <[email protected]> Co-authored-by: Mike Taves <[email protected]> Co-authored-by: mjreno <[email protected]> Co-authored-by: mjreno <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This PR does the following:
uvx hatch project metadata readme
.python3 -m build
oruv build
oruvx hatch build
etc.I've done some comparisons of the sdist (.tar.gz) and bdist (.whl) outputs, and the contents are nearly identical.