Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cryptonote_core: misc v17 consensus rules #9751

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

cryptonote_core: misc v17 consensus rules #9751

wants to merge 3 commits into from
+1,099 −1,093

Conversation

jeffro256
Copy link
Contributor

@jeffro256 jeffro256 commented Jan 29, 2025 •
edited
Loading

Adds three consensus rules for the upcoming v17 fork:

  • Rejects unlock time != 0. See discussion and existing relay rule.
  • Rejects large extra fields. See discussion and existing relay rule.
  • Rejects v1 unmixable sweep transactions. IIUC, allowing these transactions hasn't been necessary since we moved off of MLSAGs, and with FCMP++, spending these outputs has the same anonymity pool as RingCT outputs. This also reduces the attack surface with the FCMP++ integration. Is isn't foreseen that creating new v1 transactions would necessarily cause any issues with the introduction of FCMP++, but it's better to be safe than sorry.

TODO: discuss enforcing extra TLV fields are sorted for uniformity: monero-project/research-lab#61

Requires #9135 since consensus logic is streamlined in that PR

@Rucknium Rucknium mentioned this pull request Jan 29, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
consensus daemon pending review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffro256 @tobtoht