Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration options to HTTP server #9765

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vtnerd
Copy link
Contributor

@vtnerd vtnerd commented Feb 1, 2025

No description provided.

@selsta
Copy link
Collaborator

selsta commented Feb 2, 2025

What would be a scenario where someone changes rpc-response-soft-limit?

@selsta
Copy link
Collaborator

selsta commented Feb 2, 2025

This seems to break multiple functional tests, not sure if it's the IP limit or the response size limit.

@iamamyth
Copy link

iamamyth commented Feb 2, 2025

The RPC client used in those tests does a poor job of connection management: Depending on the exact version of the requests library in use, it either opens and closes a new connection for every request (recent versions of the library), or re-uses a global, "default" session, which makes it tricky to clean up. I'd check the IP limit, and also, it might be appropriate to exempt local subnets.

Edit: Based on the trace and the build setup, I expect the connection per request behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants