Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-46861-update-compass-for-new-version #719

Conversation

amalhotra-mdb
Copy link
Contributor

@amalhotra-mdb amalhotra-mdb commented Feb 3, 2025

DESCRIPTION

Update all the settings pages that instruct how to access the settings dialog box on Compass to reflect new Compass UI.

Note: the original ticket for this PR only mentions updating the Enable DevTools page in compass to reflect the new UI, however, there are many instances of procedures that navigate to the settings dialog box. So, this PR updates all instances of navigation to the Compass settings.

STAGING

JIRA

https://jira.mongodb.org/browse/DOCSP-46861

BUILD LOG

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Is this free of spelling errors?
  • Is this free of grammatical errors?
  • Is this free of staging / rendering issues?
  • Are all the links working?

External Review Requirements

What's expected of an external reviewer?

Copy link

netlify bot commented Feb 3, 2025

Deploy Preview for docs-compass ready!

Name Link
🔨 Latest commit 749971a
🔍 Latest deploy log https://app.netlify.com/sites/docs-compass/deploys/67a3859971d4cf0008c28eb4
😎 Deploy Preview https://deploy-preview-719--docs-compass.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -64,8 +63,6 @@ You can set the ``enableDevTools`` option in either:

- Mac: ``⌘`` + ``,``

.. step:: In the :guilabel:`MongoDB Compass` menu, click :guilabel:`Settings`.

|compass-short| opens a dialog box where you can configure your |compass|
settings.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't end up adding a screenshot showing the settings dialog box here, as our style guide recommends skipping screenshots for "dialog boxes that are easy to understand." (style guide)

@@ -51,11 +51,10 @@ You can set the ``enableDevTools`` option in either:
.. procedure::
:style: normal

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I didn't add the recommended "Login to compass interface" step from the original ticket for concision purposes + to avoid redundancy.

Copy link
Collaborator

@ajhuh-mdb ajhuh-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these updates @amalhotra-mdb. I added a couple suggestions that apply to each page! LMK if you have any follow-up questions!

@@ -51,11 +51,10 @@ You can set the ``enableDevTools`` option in either:
.. procedure::
:style: normal

.. step:: In the |compass-short| top menu bar, click :guilabel:`MongoDB Compass`.
.. step:: To open the |compass| Settings Panel, click the gear icon at the upper left of the |compass-short| home screen.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[suggestion] It might be a bit confusing for a user to read "upper left" and see that the gear icon is not exactly in the upper-left corner of the screenshot. Do you think we can maybe instead direct them to the "left column of the Compass home screen" ?

@@ -49,20 +49,17 @@ You can set the ``protectConnectionStrings`` option in either:
.. procedure::
:style: normal

.. step:: In the |compass-short| top menu bar, click :guilabel:`MongoDB Compass`.
.. step:: To open the |compass| Settings Panel, click the gear icon at the upper left of the |compass-short| home screen.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[suggestion] ditto the comment above regarding directional language

@@ -51,11 +51,10 @@ You can set the ``enableDevTools`` option in either:
.. procedure::
:style: normal

.. step:: In the |compass-short| top menu bar, click :guilabel:`MongoDB Compass`.
.. step:: To open the |compass| Settings Panel, click the gear icon at the upper left of the |compass-short| home screen.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[very optional suggestion] Also, I recently learned that you can make procedure steps includes. You can maybe consider making the first step of these procedures steps into an include since they're all the same.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestions @ajhuh-mdb ! I was wondering if we could do includes in procedure steps, that makes things a lot easier. Changes made, lmk if any other changes stand out to you. Thank you!

Copy link
Collaborator

@ajhuh-mdb ajhuh-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a couple more small comments before this should be ready to go! Thanks for your patience with this one @amalhotra-mdb

column of the |compass-short| home screen.

.. figure:: /images/compass/settings-gear-icon.png
:alt: Settings gear icon location on MongoDB Compass UI
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit, but do you think we can resize this image to be smaller? I don't think it needs to take up as much visual real estate as it currently does. You can adjust this with the :width: flag

@@ -0,0 +1,15 @@
To open the |compass| Settings Panel, click the gear icon on the left
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a heads up, the font for the text on this include is different from the other steps on each page. To mitigate that, we might want to include the .. step:: directive in here and format the include accordingly within the procedure directive. For example like:

Compass Settings Panel 
~~~~~~~~~~~~~~~~~~

.. procedure:: 
   :style: normal 

   .. include:: <include file path> 

   .. step:: Toggle `Enable Devtools`

^ That should render like normal.

@amalhotra-mdb
Copy link
Contributor Author

Have a couple more small comments before this should be ready to go! Thanks for your patience with this one @amalhotra-mdb

Thanks for all your help on this @ajhuh-mdb, changes made back to you!

Copy link
Collaborator

@ajhuh-mdb ajhuh-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

@ananthapai
Copy link

LGTM

@amalhotra-mdb amalhotra-mdb merged commit ee75319 into mongodb:master Feb 6, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants