DOCSP-46310 EnumRepresentationConvention constructor update #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-csharp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jordan-smith721
commented
Jan 29, 2025
source/whats-new.txt
Outdated
Comment on lines
44
to
47
| - Adds a new ``ObjectSerializerAllowedTypesConvention`` convention pack that | ||
| allows you to specify which types are allowed to be serialized and | ||
| deserialized by the object serializer. To learn more about convention packs, | ||
| see the :ref:`csharp-convention-packs` guide. |
There was a problem hiding this comment.
Note for reviewer: This section is already reviewed/approved in a separate PR (to be merged before this one)
mcmorisi
approved these changes
Jan 29, 2025
source/whats-new.txt
Outdated
Comment on lines
49
to
52
| - Adds a new constructor for the ``EnumRepresentationConvention`` class that | ||
| allows you use the ``topLevelOnly`` parameter to specify whether the | ||
| convention applies to only enum properties or to all properties that include | ||
| collections of enums, such as lists, arrays, and dictionaries. |
There was a problem hiding this comment.
Sentence feels like it runs a touch long so I cut the ending off (with the assumption that people reading this would understand what a collection is). Feel free to workshop.
Suggested change
| - Adds a new constructor for the ``EnumRepresentationConvention`` class that | |
| allows you use the ``topLevelOnly`` parameter to specify whether the | |
| convention applies to only enum properties or to all properties that include | |
| collections of enums, such as lists, arrays, and dictionaries. | |
| - Adds a new constructor for the ``EnumRepresentationConvention`` class that | |
| allows you use the ``topLevelOnly`` parameter to specify whether the | |
| convention applies to only enum properties or to all properties that include | |
| collections of enums. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-46310
Staging Links
Self-Review Checklist