Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kotlin Sync] Monitoring > Cluster Monitoring #65

Merged
merged 14 commits into from
Feb 5, 2025

Conversation

rachel-mack
Copy link
Collaborator

@rachel-mack rachel-mack commented Jan 28, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-46789

Staging Links

  • monitoring
  • index
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?

    @rachel-mack rachel-mack changed the title monitoring page [Kotlin Sync] Monitoring > Cluster Monitoring Jan 28, 2025
    Copy link

    netlify bot commented Jan 28, 2025

    Deploy Preview for docs-kotlin-sync ready!

    Name Link
    🔨 Latest commit 7b12d20
    🔍 Latest deploy log https://app.netlify.com/sites/docs-kotlin-sync/deploys/67a36f295f87f70008a21de9
    😎 Deploy Preview https://deploy-preview-65--docs-kotlin-sync.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    Copy link
    Collaborator

    @norareidy norareidy left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Nice work so far! Left some suggestions, lmk if you have questions about anything

    source/monitoring.txt Outdated Show resolved Hide resolved
    source/monitoring.txt Outdated Show resolved Hide resolved
    source/monitoring.txt Outdated Show resolved Hide resolved
    source/monitoring.txt Outdated Show resolved Hide resolved
    source/monitoring.txt Outdated Show resolved Hide resolved
    source/monitoring.txt Show resolved Hide resolved
    source/monitoring.txt Outdated Show resolved Hide resolved
    source/monitoring.txt Outdated Show resolved Hide resolved
    source/monitoring.txt Outdated Show resolved Hide resolved
    source/monitoring.txt Outdated Show resolved Hide resolved
    @rachel-mack rachel-mack requested a review from norareidy January 29, 2025 21:10
    Copy link
    Collaborator

    @norareidy norareidy left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    left some minor comments but lgtm!

    source/monitoring.txt Outdated Show resolved Hide resolved
    source/monitoring.txt Outdated Show resolved Hide resolved
    source/monitoring.txt Outdated Show resolved Hide resolved
    source/monitoring.txt Outdated Show resolved Hide resolved
    source/monitoring.txt Outdated Show resolved Hide resolved
    source/monitoring.txt Outdated Show resolved Hide resolved
    source/monitoring.txt Outdated Show resolved Hide resolved
    source/monitoring.txt Outdated Show resolved Hide resolved
    source/monitoring.txt Outdated Show resolved Hide resolved
    source/monitoring.txt Show resolved Hide resolved
    Copy link

    @nhachicha nhachicha left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    @rachel-mack thanks for adding this. The Kotlin samples need to be refactored, I left some suggestions 👍

    source/includes/monitoring_counter.kt Show resolved Hide resolved
    source/includes/monitoring_counter.kt Show resolved Hide resolved
    source/includes/monitoring_counter.kt Outdated Show resolved Hide resolved
    source/includes/monitoring_JMX.kt Outdated Show resolved Hide resolved
    source/includes/monitoring_librarian.kt Outdated Show resolved Hide resolved
    source/includes/monitoring_librarian.kt Outdated Show resolved Hide resolved
    source/includes/monitoring_librarian.kt Show resolved Hide resolved
    source/includes/monitoring_writable.kt Outdated Show resolved Hide resolved
    source/includes/monitoring_writable.kt Show resolved Hide resolved
    source/includes/monitoring_writable.kt Show resolved Hide resolved
    @rachel-mack rachel-mack requested a review from nhachicha February 3, 2025 15:52
    source/monitoring.txt Outdated Show resolved Hide resolved
    interfaces, which listen for three SDAM events each:

    - ``ClusterListener``: Listens for topology-related events
    - ``ServerListener``: Listens for events related to ``mongod`` or ``mongos`` processes

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    We're missing a conf example for ServerListener and ServerMonitorListener something like:

    .applyToServerSettings { builder ->
                builder.addServerMonitorListener(object : ServerMonitorListener {
                    override fun serverHearbeatStarted(event: ServerHeartbeatStartedEvent) {
                    }
    
                    override fun serverHeartbeatSucceeded(event: ServerHeartbeatSucceededEvent) {
                    }
    
                    override fun serverHeartbeatFailed(event: ServerHeartbeatFailedEvent) {
                    }
                })
                builder.addServerListener(object : ServerListener {
                    override fun serverOpening(event: ServerOpeningEvent) {
                    }
    
                    override fun serverClosed(event: ServerClosedEvent) {
                    }
    
                    override fun serverDescriptionChanged(event: ServerDescriptionChangedEvent) {
                    }
                })

    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    The purpose of these docs is not to be exhaustive, but to demonstrate general usage.

    Are there specific details about implementing ServerListener or ServerMonitorListener that differ from ClusterListener that you think should be demonstrated?

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    I don't have a strong opinion on this. I included these since we're dealing with telemetry, and monitoring the server's heartbeat and state could be useful.

    source/monitoring.txt Outdated Show resolved Hide resolved
    @rachel-mack rachel-mack requested a review from nhachicha February 5, 2025 14:10
    @rachel-mack rachel-mack merged commit 471ac7e into mongodb:master Feb 5, 2025
    6 checks passed
    @rachel-mack rachel-mack deleted the DOCSP-46789 branch February 5, 2025 19:52
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants