-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Kotlin Sync] Monitoring > Cluster Monitoring #65
Conversation
✅ Deploy Preview for docs-kotlin-sync ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
c34fcbb
to
00e71f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work so far! Left some suggestions, lmk if you have questions about anything
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some minor comments but lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rachel-mack thanks for adding this. The Kotlin samples need to be refactored, I left some suggestions 👍
source/monitoring.txt
Outdated
interfaces, which listen for three SDAM events each: | ||
|
||
- ``ClusterListener``: Listens for topology-related events | ||
- ``ServerListener``: Listens for events related to ``mongod`` or ``mongos`` processes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're missing a conf example for ServerListener
and ServerMonitorListener
something like:
.applyToServerSettings { builder ->
builder.addServerMonitorListener(object : ServerMonitorListener {
override fun serverHearbeatStarted(event: ServerHeartbeatStartedEvent) {
}
override fun serverHeartbeatSucceeded(event: ServerHeartbeatSucceededEvent) {
}
override fun serverHeartbeatFailed(event: ServerHeartbeatFailedEvent) {
}
})
builder.addServerListener(object : ServerListener {
override fun serverOpening(event: ServerOpeningEvent) {
}
override fun serverClosed(event: ServerClosedEvent) {
}
override fun serverDescriptionChanged(event: ServerDescriptionChangedEvent) {
}
})
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The purpose of these docs is not to be exhaustive, but to demonstrate general usage.
Are there specific details about implementing ServerListener
or ServerMonitorListener
that differ from ClusterListener
that you think should be demonstrated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a strong opinion on this. I included these since we're dealing with telemetry, and monitoring the server's heartbeat and state could be useful.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-46789
Staging Links
Self-Review Checklist