Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: mql specs #92

Merged
merged 25 commits into from
Feb 6, 2025
Merged

chore: mql specs #92

merged 25 commits into from
Feb 6, 2025

Conversation

kmruiz
Copy link
Contributor

@kmruiz kmruiz commented Nov 14, 2024

Description

Checklist

Open Questions

@kmruiz kmruiz added help wanted Extra attention is needed no release notes It's a chore and doesn't require release notes. no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) labels Nov 14, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 14, 2024 •
edited
Loading

Coverage Report

Overall Project 80.75% ✅

There is no coverage information present for the Files changed

@kmruiz kmruiz requested a review from addaleax November 21, 2024 13:03
lerouxb
lerouxb reviewed Nov 22, 2024
View reviewed changes
packages/mongodb-mql-model/src/docs/md/mql-query/mql-query.md
For example, let's consider the following query, in pseudocode:

```java
collection.aggregate(AtlasSearch(text().eq("baby one more time")))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

images

@mongodb mongodb deleted a comment from github-actions bot Nov 28, 2024
@mongodb mongodb deleted a comment from github-actions bot Nov 28, 2024
@mongodb mongodb deleted a comment from github-actions bot Nov 28, 2024
@mongodb mongodb deleted a comment from github-actions bot Nov 28, 2024
@github-actions github-actions bot added no release notes It's a chore and doesn't require release notes. and removed no release notes It's a chore and doesn't require release notes. labels Feb 4, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

🤖 Benchmark Comparison for Merge branch 'main' into chore/mql-specs

Benchmark Previous Current Change
com.mongodb.jbplugin.jmh.SampleBenchmark.init 2,612,822,969.74 ops/s 2,620,577,451.26 ops/s 0.30%

@github-actions github-actions bot added no release notes It's a chore and doesn't require release notes. and removed no release notes It's a chore and doesn't require release notes. labels Feb 4, 2025
@github-actions github-actions bot added no release notes It's a chore and doesn't require release notes. and removed no release notes It's a chore and doesn't require release notes. labels Feb 4, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

🤖 Benchmark Comparison for chore: add dialects and engines

Benchmark Previous Current Change
com.mongodb.jbplugin.jmh.SampleBenchmark.init 2,620,868,658.80 ops/s 2,596,752,813.02 ops/s -0.92%

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

🤖 Benchmark Comparison for chore: add example of type assignability

Benchmark Previous Current Change
com.mongodb.jbplugin.jmh.SampleBenchmark.init 2,620,868,658.80 ops/s 2,665,636,740.75 ops/s 1.71%

@kmruiz kmruiz marked this pull request as ready for review February 4, 2025 17:32
@github-actions github-actions bot added no release notes It's a chore and doesn't require release notes. and removed no release notes It's a chore and doesn't require release notes. labels Feb 4, 2025
@himanshusinghs himanshusinghs merged commit 4892fd3 into main Feb 6, 2025
14 checks passed
@himanshusinghs himanshusinghs deleted the chore/mql-specs branch February 6, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lerouxb lerouxb lerouxb left review comments

@addaleax addaleax addaleax left review comments

@himanshusinghs himanshusinghs himanshusinghs approved these changes

Assignees
No one assigned
Labels
help wanted Extra attention is needed no release notes It's a chore and doesn't require release notes. no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kmruiz @lerouxb @addaleax @himanshusinghs