VS-153: Enable TypesProcessor to Process Dictionaries #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BorisDog
requested changes
Jul 16, 2024
| SyntaxFactory.Identifier("List"), | ||
| SyntaxFactory.TypeArgumentList(SyntaxFactory.SeparatedList(new[] { underlyingTypeSyntax }))); | ||
| var underlyingTypeSyntaxes = namedTypeSymbol.TypeArguments.Select(typeArgument => CreateTypeSyntaxForSymbol(typeArgument)); | ||
| var collectionIdentifier = namedTypeSymbol.TypeArguments.Length switch |
There was a problem hiding this comment.
We need a better collection identification here.
What if it's MyCustomList<A,B> : IList<A> (probably good idea to add tests).
Let's determine the collection type by the actual type: Dictionary, IDictionary => Dictionary, List ... => List
| public class CustomEnumerableHolder | ||
| { | ||
| public CustomIEnumerable<int> Enumerable1 { get; set; } | ||
| public CustomIEnumerable<EnumerableHolder> Enumerable2 { get; set; } | ||
| } | ||
|
|
||
| public class CustomIDictionary<TKey, TValue> : IDictionary<TKey, TValue> |
There was a problem hiding this comment.
Let's add also ISet, Queue, Stack, just to be on the safe side.
BorisDog
requested changes
Aug 2, 2024
| @@ -253,4 +253,18 @@ private static (NodeType NodeType, INamedTypeSymbol NamedSymbol, SyntaxNode Expr | |||
|
|
|||
| return (nodeType, namedType, expressionNode); | |||
| } | |||
|
|
|||
| private static bool ProcessTypeArguments(IEnumerable<ITypeSymbol> typeArguments, TypesProcessor typesProcessor) | |||
There was a problem hiding this comment.
You could simplify with
namedType.TypeArguments.All(t => typesProcessor.ProcessTypeSymbol(t) != null)
Maybe no need for the helper method.
| public void CustomDictionaries() | ||
| { | ||
| _ = GetMongoQueryable<CustomDictionariesHolder>().Where(t => | ||
| t.IntDictionary["key"] == 1 && |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable TypesProcessor to Process Dictionaries