Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-293859: test/e2e/atlas/kube: fix tests #3553

Merged
merged 2 commits into from
Jan 21, 2025
Merged

CLOUDP-293859: test/e2e/atlas/kube: fix tests #3553

merged 2 commits into from
Jan 21, 2025

Conversation

s-urbaniak
Copy link
Collaborator

@s-urbaniak s-urbaniak commented Jan 20, 2025 •
edited
Loading

Proposed changes

Jira ticket: CLOUDP-293859

This fixes the re-enabled tests that have been turned on as part of #3530.

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

@s-urbaniak s-urbaniak requested review from a team as code owners January 20, 2025 13:59
blva
blva previously approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@blva blva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if LGTEV! thanks for fixing! cc @cveticm if we can copy those to the plugin 🚀

cveticm
cveticm previously approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@cveticm cveticm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

helderjs
helderjs previously approved these changes Jan 20, 2025
View reviewed changes
josvazg
josvazg previously approved these changes Jan 20, 2025
View reviewed changes
@s-urbaniak s-urbaniak dismissed stale reviews from josvazg, helderjs, and cveticm via 27c2ec1 January 21, 2025 07:13
@apix-bot APIx Bot
Copy link
Contributor

apix-bot bot commented Jan 21, 2025

Coverage Report 📉

Branch Commit Coverage
master 3b98d4a 38.9%
CLOUDP-293859 27c2ec1 38.8%
Difference -.1%

@s-urbaniak s-urbaniak merged commit f86489a into master Jan 21, 2025
22 checks passed
@s-urbaniak s-urbaniak deleted the CLOUDP-293859 branch January 21, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cveticm cveticm cveticm approved these changes

@josvazg josvazg josvazg approved these changes

@gssbzn gssbzn gssbzn approved these changes

@blva blva blva left review comments

@helderjs helderjs helderjs left review comments

Assignees
No one assigned
Labels
atlascli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@s-urbaniak @helderjs @gssbzn @josvazg @blva @cveticm