DRIVERS-1872 Add sessions spec tests to verify explicit sessions were created on the correct client #1754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he correct client
ShaneHarvey
reviewed
Feb 7, 2025
| client: *client1 | ||
|
|
||
| tests: | ||
| - description: Session argument is for the right client (insertOne) |
There was a problem hiding this comment.
It's expensive to setup and teardown each of these tests. Could we combine all of these tests into one to avoid that problem?
qingyang-hu
requested review from
dariakp and
sanych-sun
and removed request for
a team
sanych-sun
reviewed
Feb 26, 2025
| models: [] | ||
| session: *session1 | ||
| expectError: | ||
| isClientError: true |
There was a problem hiding this comment.
Where from we get the list of operations? Should we also test the following commands (I've reviewed C# Driver public API that accepts session as a parameter)?
- MongoClient.DropDatabase
- MongoClient.ListDatabaseNames
- MongoClient.Watch
- MongoDatabase.CreateCollection
- MongoDatabase.CreateView
- MongoDatabase.RenameCollection
- MongoDatabase.RunCommand
- MongoDatabase.Watch
- Collection.AggregateToCollection
- Collection.Watch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRIVERS-1872
Please complete the following before merging:
clusters, and serverless).