feat: Disable Signups for new users #7254
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
davpsh
commented
May 2, 2024
davpsh
commented
May 2, 2024
asbiin
requested changes
May 4, 2024
Co-authored-by: Alexis Saettler <[email protected]>
Co-authored-by: Alexis Saettler <[email protected]>
Co-authored-by: Alexis Saettler <[email protected]>
Co-authored-by: Alexis Saettler <[email protected]>
davpsh
changed the title
@asbiin, can you give feedback on the current state of the code? Is there anything else that needs to be fixed? |
asbiin
requested changes
Feb 1, 2025
Comment on lines
+18
to
+22
| public function __construct( | ||
| protected SignupHelper $signupHelper | ||
| ) { | ||
| } | ||
|
|
There was a problem hiding this comment.
This isn't working actually
Suggested change
| public function __construct( | |
| protected SignupHelper $signupHelper | |
| ) { | |
| } |
| @@ -40,6 +46,7 @@ public function __invoke(Request $request): Response | |||
| } | |||
|
|
|||
| return Inertia::render('Auth/Login', $data + [ | |||
| 'isSignupEnabled' => $this->signupHelper->isEnabled(), | |||
There was a problem hiding this comment.
This should fix it
Suggested change
| 'isSignupEnabled' => $this->signupHelper->isEnabled(), | |
| 'isSignupEnabled' => app(SignupHelper::class)->isEnabled(), |
Comment on lines
+14
to
+21
| public function __construct( | ||
| protected SignupHelper $signupHelper, | ||
| ) { | ||
| } | ||
|
|
||
| public function handle(Request $request, Closure $next): Response | ||
| { | ||
| abort_if(! $this->signupHelper->isEnabled(), 403, trans('Registration is currently disabled')); |
There was a problem hiding this comment.
Suggested change
| public function __construct( | |
| protected SignupHelper $signupHelper, | |
| ) { | |
| } | |
| public function handle(Request $request, Closure $next): Response | |
| { | |
| abort_if(! $this->signupHelper->isEnabled(), 403, trans('Registration is currently disabled')); | |
| public function handle(Request $request, Closure $next): Response | |
| { | |
| abort_if(! app(SignupHelper::class)->isEnabled(), 403, trans('Registration is currently disabled')); |
| use Tests\TestCase; | ||
|
|
||
| class RegistrationTest extends TestCase | ||
| { | ||
| use DatabaseTransactions; | ||
|
|
||
| #[Test] | ||
| public function registration_screen_can_be_rendered() | ||
| public function testAccessToRegistrationPage(): void |
There was a problem hiding this comment.
Let's keep the new syntax
Suggested change
| public function testAccessToRegistrationPage(): void | |
| #[Test] | |
| public function registration_screen_can_be_rendered(): void |
| use Laravel\Jetstream\Jetstream; | ||
| use PHPUnit\Framework\Attributes\Test; | ||
| use Mockery; |
There was a problem hiding this comment.
Suggested change
| use Mockery; | |
| use PHPUnit\Framework\Attributes\Test; | |
| use Mockery; |
| } | ||
|
|
||
| #[Test] | ||
| public function new_users_can_register() | ||
| public function testRegistration(): void |
There was a problem hiding this comment.
Suggested change
| public function testRegistration(): void | |
| #[Test] | |
| public function new_users_can_register() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow to enable/disable new user registration based on ENV setting. The feature was implemented in version 4.x and was not present in chandler. Fixes #6687
Changes:
APP_DISABLE_SIGNUP