Add possibility to subscribe to changes of language packs #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bended original local_amos_filter class for our output Changes to be committed: modified: lang/en/local_amos.php modified: lib.php modified: locallib.php modified: renderer.php new file: subscription.php modified: yui/filter/filter.js
Including phpunit tests, mail templates and first sql queries for the changes of lang strings
We now have the language on the same level as we have the component name. However, we might have multiple entries for the same component, but only one for each component-lang combination.
Changes to be committed: new file: classes/local/subscription_table.php modified: lang/en/local_amos.php modified: renderer.php modified: subscription.php
Changes to be committed: modified: classes/local/subscription_table.php modified: lang/en/local_amos.php modified: renderer.php modified: subscription.php
Changes to be committed: modified: classes/local/subscription_table.php modified: subscription.php
Kudos to all people there for the hard work 👍 🎈 🎉! |
|
I am sorry. I did not forget about this one, only did not have a chance to get to it yet. |
|
Still being aware of this feature request. But the things seem to evolve a bit and we are currently evaluating https://weblate.org as a system that would replace the AMOS translation UI. And it has various reporting and notification features in-built (among other nice things). So it may be that this request will be solved by that. Will keep you informed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a plugin maintainer, I am interested in changes to language strings of my plugin, which are made via amos. This PR adds a new UI to subscribe to various combinations of language and component. A cron task then runs daily in the background and sends mail notifications to the user, for every update during the last day, but only if the user subscribed to the changes.
Thanks to all the other contributors at MoodleMootDACH19