Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Parameters Pallet #1100

Merged
merged 13 commits into from
Feb 18, 2025
Merged

Add Parameters Pallet #1100

merged 13 commits into from
Feb 18, 2025

Conversation

themacexpert
Copy link
Contributor

Description

Add a page on the Parameters pallet to the substrate governance pallets section.

Checklist

  • I have added a label to this PR 🏷️
  • I have run my changes through Grammarly

Corresponding PRs

Please link to any corresponding PRs here.

After Translation Requirements

Items to be Updated

Please list any of the items that will need to be added or deleted after the translations are done here.

@themacexpert themacexpert added A0 - New Content Pull request contains new content pages B0 - Needs Review Pull request is ready for review labels Feb 6, 2025
Copy link
Contributor

@dawnkelly09 dawnkelly09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't spun this up yet but a few Grammarly things

Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few remaining things

@themacexpert themacexpert requested a review from eshaben February 12, 2025 01:57
Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweeet! LGTM!

@themacexpert themacexpert added B1 - Ready to Merge Pull request is ready to be merged and removed B0 - Needs Review Pull request is ready for review labels Feb 12, 2025
Copy link
Contributor

@dawnkelly09 dawnkelly09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@eshaben eshaben merged commit eaa534a into master Feb 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0 - New Content Pull request contains new content pages B1 - Ready to Merge Pull request is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants