Skip to content

Commit

Permalink
Fix features not being passed to cargo-build template (#2486)
Browse files Browse the repository at this point in the history
* Fix features not being passed to cargo-build template
* Remove evm-tracing feature from coverage job
* Remove build-features action
  • Loading branch information
tmpolaczyk authored Dec 12, 2023
1 parent 433dda2 commit 4891e81
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 23 deletions.
4 changes: 2 additions & 2 deletions .github/workflow-templates/cargo-build/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ runs:
run: |
env
params=" --locked --release -p moonbeam"
if [ -n "${{ github.event.inputs.features }}" ]; then
params="$params --features ${{ github.event.inputs.features }}"
if [ -n "${{ inputs.features }}" ]; then
params="$params --features ${{ inputs.features }}"
fi
echo "cargo build $params"
cargo build $params
Expand Down
19 changes: 0 additions & 19 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -307,25 +307,6 @@ jobs:
name: moonbeam
path: build

build-features:
runs-on:
labels: bare-metal
needs: ["set-tags"]
steps:
- name: Checkout
uses: actions/checkout@v3
with:
ref: ${{ needs.set-tags.outputs.git_ref }}
- name: Cargo build
uses: ./.github/workflow-templates/cargo-build
with:
features: "try-runtime"
- name: Upload binary
uses: actions/[email protected]
with:
name: moonbeam-features
path: build

rust-test:
runs-on:
labels: bare-metal
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,6 @@ jobs:
run: rustup component add llvm-tools-preview
- name: Cargo build
uses: ./.github/workflow-templates/cargo-build
with:
features: evm-tracing
- name: Enable coverage gathering
run: |
# Enable coverage when running tests
Expand Down

0 comments on commit 4891e81

Please sign in to comment.