Skip to content

Commit

Permalink
Remove feature moonbase-runtime-benchmarks (#3163)
Browse files Browse the repository at this point in the history
* refactor: 🔥 remove feature moonbase-runtime-benchmarks

* style: 🎨 revert formatting changes
  • Loading branch information
manuelmauro authored Jan 29, 2025
1 parent 31700d6 commit 64f1037
Show file tree
Hide file tree
Showing 6 changed files with 1 addition and 28 deletions.
3 changes: 1 addition & 2 deletions .cargo/config.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
[alias]
moonbase = " build --release -p moonbeam --no-default-features --features moonbase-native"
moonbase-benchmarks = " build --release -p moonbeam --no-default-features --features moonbase-runtime-benchmarks"
moonbase-rococo = " build --release -p moonbeam --no-default-features --features moonbase-native,rococo-native"
moonriver = " build --release -p moonbeam --no-default-features --features moonriver-native"
moonriver-rococo = " build --release -p moonbeam --no-default-features --features moonriver-native,rococo-native"
Expand Down Expand Up @@ -40,5 +39,5 @@ rustflags = [
"-Aclippy::while_immutable_condition", # false positives
"-Aclippy::needless_option_as_deref", # false positives
"-Aclippy::derivable_impls", # false positives
"-Aclippy::explicit_counter_loop" # irrelevant
"-Aclippy::explicit_counter_loop", # irrelevant
]
6 changes: 0 additions & 6 deletions node/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,3 @@ runtime-benchmarks = [
"pallet-xcm/runtime-benchmarks",
"xcm-builder/runtime-benchmarks",
]

moonbase-runtime-benchmarks = [
"moonbeam-cli/moonbase-runtime-benchmarks",
"pallet-xcm/runtime-benchmarks",
"xcm-builder/runtime-benchmarks",
]
2 changes: 0 additions & 2 deletions node/cli/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -67,5 +67,3 @@ runtime-benchmarks = [
"moonbeam-service/runtime-benchmarks",
"polkadot-service/runtime-benchmarks",
]

moonbase-runtime-benchmarks = ["moonbeam-service/moonbase-runtime-benchmarks"]
9 changes: 0 additions & 9 deletions node/cli/src/command.rs
Original file line number Diff line number Diff line change
Expand Up @@ -538,15 +538,6 @@ pub fn run() -> Result<()> {
#[cfg(not(feature = "moonbase-native"))]
_ => panic!("invalid chain spec"),
}
} else if cfg!(feature = "moonbase-runtime-benchmarks") {
#[cfg(feature = "moonbase-native")]
return runner.sync_run(|config| {
cmd.run_with_spec::<HashingFor<moonbeam_service::moonbase_runtime::Block>, HostFunctions>(
Some(config.chain_spec),
)
});
#[cfg(not(feature = "moonbase-native"))]
panic!("Benchmarking wasn't enabled when building the node.");
} else {
Err("Benchmarking wasn't enabled when building the node. \
You can enable it with `--features runtime-benchmarks`."
Expand Down
7 changes: 0 additions & 7 deletions node/service/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -226,10 +226,3 @@ try-runtime = [
"moonbase-runtime/try-runtime",
"polkadot-service/try-runtime",
]

moonbase-runtime-benchmarks = [
"moonbase-native",
"moonbase-runtime/moonbase-runtime-benchmarks",
"moonbase-runtime/runtime-benchmarks",
"pallet-ethereum/runtime-benchmarks",
]
2 changes: 0 additions & 2 deletions runtime/moonbase/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -463,5 +463,3 @@ try-runtime = [
"pallet-async-backing/try-runtime",
"pallet-precompile-benchmarks/try-runtime",
]

moonbase-runtime-benchmarks = []

0 comments on commit 64f1037

Please sign in to comment.