Skip to content

Commit

Permalink
Enforce minimum [pnpm, node] versions when running typescript tests (#…
Browse files Browse the repository at this point in the history
…2632)

* Enforce minimum engine versions when running typescript tests
* chore(ci): set node-version (20.10.0) explicitly in all github actions
  • Loading branch information
RomarQ authored Jan 31, 2024
1 parent d4fdae0 commit 806347a
Show file tree
Hide file tree
Showing 11 changed files with 29 additions and 24 deletions.
2 changes: 1 addition & 1 deletion .github/workflow-templates/dev-tests/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ runs:
version: 8.6.12
- uses: actions/setup-node@v3
with:
node-version: 20.10
node-version: 20.10.0
cache: "pnpm"
cache-dependency-path: test/pnpm-lock.yaml

Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -201,10 +201,10 @@ jobs:
uses: pnpm/action-setup@v2
with:
version: 8.6.12
- name: Use Node.js 20.10
- name: Use Node.js
uses: actions/setup-node@v3
with:
node-version: 20.10
node-version: 20.10.0
cache: "pnpm"
cache-dependency-path: test/pnpm-lock.yaml
- name: Run Eslint check
Expand Down Expand Up @@ -417,10 +417,10 @@ jobs:
uses: pnpm/action-setup@v2
with:
version: 8.6.12
- name: Use Node.js 20.10
- name: Use Node.js
uses: actions/setup-node@v3
with:
node-version: 20.10
node-version: 20.10.0
cache: "pnpm"
cache-dependency-path: test/pnpm-lock.yaml
- run: |
Expand Down Expand Up @@ -543,7 +543,7 @@ jobs:
version: 8
- uses: actions/setup-node@v3
with:
node-version: 20.10
node-version: 20.10.0
cache: "pnpm"
cache-dependency-path: test/pnpm-lock.yaml
- name: Create local folders
Expand Down Expand Up @@ -591,7 +591,7 @@ jobs:
version: 8
- uses: actions/setup-node@v3
with:
node-version: 20.10
node-version: 20.10.0
- name: Create local folders
run: |
mkdir -p target/release/wbuild/${{ matrix.chain }}-runtime/
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/client-release-issue.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,10 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v3
- name: Use Node.js 18.x
- name: Use Node.js
uses: actions/setup-node@v3
with:
node-version: 18.x
node-version: 20.10.0
- name: Download Original Tools
uses: actions/download-artifact@v3
with:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/publish-binary.yml
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,10 @@ jobs:
with:
name: binaries
path: build
- name: Use Node.js 18.x
- name: Use Node.js
uses: actions/setup-node@v3
with:
node-version: 18.x
node-version: 20.10.0
- name: Download Original Tools
uses: actions/download-artifact@v3
with:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/publish-runtime.yml
Original file line number Diff line number Diff line change
Expand Up @@ -135,10 +135,10 @@ jobs:
with:
name: moonbeam-runtime
path: build
- name: Use Node.js 18.x
- name: Use Node.js
uses: actions/setup-node@v3
with:
node-version: 18.x
node-version: 20.10.0
- name: Download Original Tools
uses: actions/download-artifact@v3
with:
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/publish-typescript-api.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ jobs:
uses: actions/checkout@v3
with:
ref: ${{ github.event.inputs.sha }}
- name: Use Node.js 20.10
- name: Use Node.js
uses: actions/setup-node@v3
with:
node-version: 20.10
node-version: 20.10.0
- name: Build typescript API
run: |
cd typescript-api
Expand All @@ -37,10 +37,10 @@ jobs:
uses: actions/checkout@v3
with:
ref: ${{ github.event.inputs.sha }}
- name: Use Node.js 20.10
- name: Use Node.js
uses: actions/setup-node@v3
with:
node-version: 20.10
node-version: 20.10.0
- name: Upgrade polkadotjs for tests
run: |
cd test
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/runtime-release-issue.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v3
- name: Use Node.js 18.x
- name: Use Node.js
uses: actions/setup-node@v3
with:
node-version: 18.x
node-version: 20.10.0
- name: Download Original Tools
uses: actions/download-artifact@v3
with:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/upgrade-typescript-api.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ jobs:
mkdir -p build
docker cp dummy:/moonbeam/moonbeam build/moonbeam
docker rm -f dummy
- name: Use Node.js 20.10
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: 20.9.0
node-version: 20.10.0
- name: Use pnpm
uses: pnpm/action-setup@v2
with:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/version-bump.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v3
- name: Use Node.js 18.x
- name: Use Node.js
uses: actions/setup-node@v3
with:
node-version: 18.x
node-version: 20.10.0
- name: Generate version bump issue
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand Down
3 changes: 2 additions & 1 deletion test/.npmrc
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
ignore-workspace-root-check = true
strict-peer-dependencies = false
registry = https://registry.npmjs.org/
auto-install-peers = true
auto-install-peers = true
engine-strict=true
4 changes: 4 additions & 0 deletions test/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -66,5 +66,9 @@
"prettier": "2.8.8",
"typescript": "5.3.3",
"yargs": "17.7.2"
},
"engines": {
"pnpm": ">=8.6",
"node": ">=20.10.0"
}
}

0 comments on commit 806347a

Please sign in to comment.