Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(moonbeam, moonriver): support evm native foreign assets in xcm transactor #3203

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(moonbeam, moonriver): support evm native foreign assets in xcm transactor #3203

wants to merge 3 commits into from
+336 −147

Conversation

RomarQ
Copy link
Contributor

@RomarQ RomarQ commented Mar 3, 2025 •
edited
Loading

What does it do?

Enables assets manager by EvmForeignAssets to used in the xcm transactor.

@RomarQ RomarQ added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes evm-native-foreign-assets labels Mar 3, 2025
@RomarQ RomarQ self-assigned this Mar 3, 2025
@RomarQ RomarQ changed the title fix(moonbeam, moonriver): support evm native foreign assets in xcm executor fix(moonbeam, moonriver): support evm native foreign assets in xcm transactor Mar 3, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 3, 2025 •
edited
Loading

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2420 KB (no changes) 🚨

Moonbeam runtime: 2400 KB (-8 KB) ✅

Moonriver runtime: 2412 KB (no changes) 🚨

Compared to latest release (runtime-3501)

Moonbase runtime: 2420 KB (+468 KB compared to latest release) 🚨

Moonbeam runtime: 2400 KB (+460 KB compared to latest release) ⚠️

Moonriver runtime: 2412 KB (+472 KB compared to latest release) 🚨

@RomarQ RomarQ added the not-breaking Does not need to be mentioned in breaking changes label Mar 3, 2025
@RomarQ RomarQ added the D3-trivial PR contains trivial changes in a runtime directory that do not require an audit label Mar 3, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 3, 2025 •
edited
Loading

Coverage Report

@@                    Coverage Diff                    @@
##           master   rq/fix-xcm-transactor      +/-   ##
=========================================================
+ Coverage   74.51%                  74.58%   +0.07%     
  Files         381                     381              
+ Lines       96551                   96700     +149     
=========================================================
+ Hits        71940                   72117     +177     
- Misses      24611                   24583      -28
Files Changed Coverage
/runtime/moonbeam/src/xcm_config.rs 56.73% (+13.46%) 🔼
/runtime/moonbeam/tests/common/mod.rs 95.16% (+0.36%) 🔼
/runtime/moonbeam/tests/integration_test.rs 99.43% (+0.02%) 🔼
/runtime/moonriver/src/xcm_config.rs 56.73% (+13.46%) 🔼
/runtime/moonriver/tests/common/mod.rs 95.25% (+0.34%) 🔼
/runtime/moonriver/tests/integration_test.rs 99.40% (+0.01%) 🔼

Coverage generated Mon Mar 3 18:38:17 UTC 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TarekkMA TarekkMA Awaiting requested review from TarekkMA

@manuelmauro manuelmauro Awaiting requested review from manuelmauro

@pLabarta pLabarta Awaiting requested review from pLabarta

At least 1 approving review is required to merge this pull request.

Assignees

@RomarQ RomarQ

Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit evm-native-foreign-assets not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RomarQ