Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to new block import strategy #3204

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

snowmead
Copy link

@snowmead snowmead commented Mar 3, 2025

What does it do?

This PR updates the CLI to default to the new block import strategy (blocks being considered best when imported) originally being optional via the --experimental-block-import-strategy parameter.

⚠️ Breaking Changes ⚠️

CLI no longer accepts --experimental-block-import-strategy parameter and is now replaced with --legacy-block-import-strategy for nodes who want to use the old block import strategy.

@snowmead snowmead marked this pull request as ready for review March 3, 2025 20:52
Copy link
Contributor

@RomarQ RomarQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RomarQ RomarQ added B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes breaking Needs to be mentioned in breaking changes D2-notlive PR doesn't change runtime code (so can't be audited) labels Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes breaking Needs to be mentioned in breaking changes D2-notlive PR doesn't change runtime code (so can't be audited)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants