Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change queries for erc20 interfaces #438

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Conversation

mmaurello
Copy link
Contributor

@mmaurello mmaurello commented Feb 5, 2025

Description

Before the migration of all XC20s to ERC20 interface in Moonbeam chains, adapt the SDK by changing all the xc20 interfaces queries to ERC20 interfaces in assets for Moonbeam, Moonriver and Moonbase Alpha

This includes not only the Moonchains config files, but all the files that have some routes to these chains. Applied also to MRL configs

=============>
I M P O R T A N T: This has to be merged and released in the dapp before the migrations happen for Moonbeam and Moonriver.
The idea is to test a migration in Moonbase-Alpha first before testing all this
<=============

Checklist

  • If this requires a documentation change, I have created a PR that updates the mkdocs/docs directory
  • If this requires it, I have updated the Readme
  • If necessary, I have updated the examples
  • I have verified if I need to create/update unit tests
  • I have verified if I need to create/update acceptance tests
  • If necessary, I have run acceptance tests on this branch in CI

Copy link

changeset-bot bot commented Feb 5, 2025

🦋 Changeset detected

Latest commit: eca6b85

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@moonbeam-network/xcm-config Patch
@moonbeam-network/mrl Patch
@moonbeam-network/xcm-sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mmaurello mmaurello changed the title change queries for xcUnit to use erc20 interfaces Change queries for erc20 interfaces Feb 5, 2025
@mmaurello mmaurello marked this pull request as ready for review February 14, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants