Update cpu check to have better warning #3757
Draft
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When using HF models with mixed init, we can mistakenly throw the warning below, which indicates that the model is not going to be training on GPU. this is not actually the case and we should not throw the warning if using mixed init.
Warning message below indicates that the model is on cpu instead of GPU, which is confusing for users when they specify mixed init (for example, with HF models.)
Testing
Without changes, mcli logs embedding-ft-r3jodb --follow:
With changes, mcli logs embedding-ft-Lf9M5o --follow:
The memory monitor only works on CUDA devices, but the model is on {model_device.type}.
isn't in the logs.
https://databricks.atlassian.net/browse/GRT-3119
Before submitting
pre-commit
on your change? (see thepre-commit
section of prerequisites)