-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify new nav for old IE basic styling #15874
Open
janbrasna
wants to merge
12
commits into
mozilla:main
Choose a base branch
from
janbrasna:add/nav-refresh-ie-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15874 +/- ##
==========================================
+ Coverage 79.28% 79.57% +0.28%
==========================================
Files 159 160 +1
Lines 8343 8396 +53
==========================================
+ Hits 6615 6681 +66
+ Misses 1728 1715 -13 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this changeset needs to go into the FXC codebase, please add the
WMO and FXC
label. 🤷 (yes, this will need re-applying to fxc 🔥🦊 with different paths)One-line summary
Streamlines the experience for IE9- and polishes a bit more in IE8- to make the site usable with recent (mostly m24) styling additions.
Significant changes and points to review
Constrains refreshed header & footer to just top level nav items without any interaction, for better usability and scanability of the rest of pages.
Improves some basic alignment and adds alternatives for key SVG affordances (to not look broken in places where it is used for navigation/interaction, removing large objects with rendering issues like header flag or footer wordmark, augmenting download steps with plaintext pseudo content to allow navigation etc., while keeping product logos in menus for IE versions that can support that).
Removes fallback styling overrides ("enhancements") that try to inject full modern bundles (incl. current base m24 styles) for otherwise base-less legacy-only pages like fx/desktop, as it was only making the experience worse, not better. Being covered by the common-IE bundle like everywhere else, with the added extra desktop/ie* still for enhanced styling of the components there, seems to serve such clients better, also being more stable and predictable (=frozen in time, instead of blindly serving full modern bundles' changes over time…)
Also cleans up some superfluous meta and duplicate hyphenation for ?xv=basic e.g. fx/mac or fx/linux for everyone while at it… SERPs strip what's after the hyphen anyway, or use the shorter opengraph content…
Tweaks the ESR/unsupported CTAs as these are now the default for such platforms+UAs.
(+tiny RTL fixes.)
(Also, with the switch to ESR and ESR download button macro magic, these UAs skip the download/thanks flow anyways and request direct bouncer links, so no need to keep enhancing paths not being taken any longer.)
Removes custom IE8-9 styles that no longer need to be styled, being covered by the common-ie base protocol tweaks sufficiently.
NB: Updates browser compatibility info in docs with some more precise datapoints.
Issue / Bugzilla link
Fixes #15867
Testing
http://localhost:8000/en/
http://localhost:8000/fy/firefox/new/
http://localhost:8000/en/firefox/new/?xv=basic
http://localhost:8000/cy/firefox/windows/
http://localhost:8000/en/firefox/download/thanks/?xv=basic
http://localhost:8000/sco/firefox/download/thanks/
http://localhost:8000/he/firefox/all/desktop-esr/win/
http://localhost:8000/ar/about/
http://localhost:8000/el/ (og home)
http://localhost:8000/pl/ (og nav)
🚧 TKTK fresh screen captures