-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update wordmarks and logos #15975
base: main
Are you sure you want to change the base?
Update wordmarks and logos #15975
Conversation
ab502a1
to
6dc6046
Compare
This comment was marked as resolved.
This comment was marked as resolved.
@@ -12,7 +12,7 @@ | |||
{% block body_class %}mzp-t-mozilla format-none{% endblock%} | |||
{% block body_id %}privacy-landing{% endblock %} | |||
|
|||
{% block article_header_logo %}{{ static('img/trademarks/logo-mozm.png') }}{% endblock %} | |||
{% block article_header_logo %}{{ static('img/trademarks/symbol.svg') }}{% endblock %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was suggested to use the green flag with black background here, but I've gone with the asset that exists in the trademarks
folder for simplicity (https://www.mozilla.org/en-US/foundation/trademarks/list/). Should I copy the png favicon for more general use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure who the authority is on this - but I like what you've done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"BIMI requires SVG version of favicon"
I think BIMI doesn't work at all currently, or the set up was never really finished given the absence from DNS. (Or the verification at the TLS cert provider side was the issue? Maybe someone with access to https://bugzil.la/1738806 can check its fate.)
https://bimigroup.org/bimi-generator/ validator shows no records for:
email.mozilla.org
em.mozilla.org
e.mozilla.org
mozilla.org
TL;DR no need to put any extra effort into BIMI assets unless requested again I guess. As the SVG needs to use TinyPS profile therefore some manual checks/tweaks etc. it's an extra effort:(
<link rel="shortcut icon" href="{% block page_favicon %}{% if switch('m24-website-refresh') %}{{ static('img/favicons/mozilla/m24/favicon.ico') }}{% else %}{{ static('img/favicons/mozilla/favicon.ico') }}{% endif %}{% endblock %}"> | ||
<link rel="apple-touch-icon" type="image/png" sizes="180x180" href="{% block page_ios_icon %}{{ static('img/favicons/mozilla/apple-touch-icon.png') }}{% endblock %}"> | ||
<link rel="icon" type="image/png" sizes="196x196" href="{% block page_favicon_large %}{{ static('img/favicons/mozilla/favicon-196x196.png') }}{% endblock %}"> | ||
<link rel="shortcut icon" href="{% block page_favicon %}{{ static('img/favicons/mozilla/favicon.ico') }}{% endblock %}"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Also there are no m24 replacements for the 16x16 & 32x32 sizes (yet, we could add if needed)"
They were only added in #7889/files wholesale in a batch, for consistency/availability — but never consumed since (or used before), as in #7916/files — so it's safe to omit them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maureenlholland So the TinyPS is pretty feasible for the flag shape — I've made a -bimi variant if you wanna update that one as well to… well… not keep an old asset around;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the SVG, gonna link this in a separate BIMI-specific issue
8c26cc3
to
1f0b5a0
Compare
waiting for stakeholder feedback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not 100% sure this will work, esp. for CSP reasons, with a raster image embedded as a datauri; and something running as "a script" that might get sandboxed.
(WebKit makes it look like there's something broken: …)

Should I look into it, to try to replace the inline PNG with some vector alternative?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(NB: the base64 datauri seems to be empty/invalid PNG anyways — was there something in the original asset perhaps? The original PNG had a Fx logo in white there on the mug…)
https://jaredwinick.github.io/base64-image-viewer/
data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAZ4AAAGeCAYAAACkfGcPAAAgAElEQVR4nO3db1bcRro/8FJJ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these might not be final images, so you can ignore for now, thanks for the info though! will keep an eye on it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cleaned up the svg, if embedded data-based images are important to studio team, I'll re-request and explain the issue, but I think these are interim images to better match the refresh branding until a more comprehensive update is ready, so not high priority
edb0012
to
06c4f63
Compare
Images could be offices or coworking spaces
06c4f63
to
cbc5fd7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15975 +/- ##
=======================================
Coverage 79.57% 79.57%
=======================================
Files 160 160
Lines 8396 8396
=======================================
Hits 6681 6681
Misses 1715 1715 ☔ View full report in Codecov by Sentry. |
If this changeset needs to go into the FXC codebase, please add the
WMO and FXC
label.One-line summary
Brings in new refresh mozilla symbol where possible
NOTES:
mozm.png
,mozilla/logo
,mozilla-256.jpg
BIMI requires SVG version of favicon:Setup Brand Indicators for Message Indentification (BIMI) for Mozilla Emails #10490Significant changes
Replaces root favicons with m24 favicons (names do not change, not sure if this is an issue). Also there are no m24 replacements for the 16x16 & 32x32 sizes (yet, we could add if needed)
Issue / Bugzilla link
#15682
Testing