-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update VPN product pages with extension related changes (fix #15983) #16006
base: main
Are you sure you want to change the base?
Conversation
c2e1807
to
37d1740
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16006 +/- ##
=======================================
Coverage 79.57% 79.57%
=======================================
Files 160 160
Lines 8396 8396
=======================================
Hits 6681 6681
Misses 1715 1715 ☔ View full report in Codecov by Sentry. |
37d1740
to
29176fe
Compare
I haven’t pulled this PR locally yet to take a look, but I notice there’s quite a lot of new strings here. Do we need to think about fallbacks for older translations at all? We generally try not to show a lot of mixed English copy in places, unless it’s unavoidable. Maybe that discussion has already been had, just calling it out in case. |
@alexgibson The new strings are on three pages:
Please let me know your thoughts on if any of the old strings should be used for fallbacks, especially the ones on the landing page |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates look good! I'm not sure the new link on the download page is quite working as expected depending on operating system. But other than that, just a few small suggestions.
<div class="platform-body"> | ||
<h2>{{ ftl('vpn-download-for-windows-v2') }}</h2> | ||
<p>{{ ftl('vpn-download-for-windows-requirements') }}</p> | ||
<div class="secondary-platform-wrapper"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh one other question: when is this all due to launch? Does any of it need to be behind a switch? |
29176fe
to
bd8982f
Compare
bd8982f
to
fd63197
Compare
If this changeset needs to go into the FXC codebase, please add the
WMO and FXC
label.One-line summary
This PR updates the VPN product pages with extension related changes
Significant changes and points to review
See GH issue for details
Issue / Bugzilla link
#15983
Testing
http://localhost:8000/en-US/products/vpn/
http://localhost:8000/en-US/products/vpn/features/
http://localhost:8000/en-US/products/vpn/download/