Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update VPN product pages with extension related changes (fix #15983) #16006

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wen-2018
Copy link
Collaborator

@wen-2018 wen-2018 commented Feb 18, 2025

If this changeset needs to go into the FXC codebase, please add the WMO and FXC label.

One-line summary

This PR updates the VPN product pages with extension related changes

Significant changes and points to review

See GH issue for details

Issue / Bugzilla link

#15983

Testing

http://localhost:8000/en-US/products/vpn/
http://localhost:8000/en-US/products/vpn/features/
http://localhost:8000/en-US/products/vpn/download/

@wen-2018 wen-2018 force-pushed the vpn-extension-updates branch from c2e1807 to 37d1740 Compare February 18, 2025 16:55
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.57%. Comparing base (87f9f94) to head (fd63197).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16006   +/-   ##
=======================================
  Coverage   79.57%   79.57%           
=======================================
  Files         160      160           
  Lines        8396     8396           
=======================================
  Hits         6681     6681           
  Misses       1715     1715           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wen-2018 wen-2018 force-pushed the vpn-extension-updates branch from 37d1740 to 29176fe Compare February 18, 2025 18:22
@wen-2018 wen-2018 added Needs Review Awaiting code review Frontend HTML, CSS, JS... client side stuff labels Feb 18, 2025
@wen-2018 wen-2018 marked this pull request as ready for review February 18, 2025 18:26
@wen-2018 wen-2018 requested a review from a team as a code owner February 18, 2025 18:26
@alexgibson
Copy link
Member

I haven’t pulled this PR locally yet to take a look, but I notice there’s quite a lot of new strings here. Do we need to think about fallbacks for older translations at all? We generally try not to show a lot of mixed English copy in places, unless it’s unavoidable. Maybe that discussion has already been had, just calling it out in case.

@wen-2018
Copy link
Collaborator Author

Do we need to think about fallbacks for older translations at all?

@alexgibson The new strings are on three pages:

  • the landing page
    The new strings on this page is corresponding to the new image update. I removed the old ones since they are describing a feature for the old image

  • the feature page
    This new string are for a new feature section and the old section with old strings are removed from the page. Since the new section is also added at the top, GH comparison made it look at a lot more strings are changed. In reality, it is removing the last section and adding a new one at the top

  • the download page
    This purely adding a new link with a new string

Please let me know your thoughts on if any of the old strings should be used for fallbacks, especially the ones on the landing page

Copy link
Member

@alexgibson alexgibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates look good! I'm not sure the new link on the download page is quite working as expected depending on operating system. But other than that, just a few small suggestions.

<div class="platform-body">
<h2>{{ ftl('vpn-download-for-windows-v2') }}</h2>
<p>{{ ftl('vpn-download-for-windows-requirements') }}</p>
<div class="secondary-platform-wrapper">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue: (possibly blocking) I'm not 100% sure what the expected behavior is here, but when visiting on a Windows device, I don't seem to see this new link:

image

When visiting on macOS (and Windows is a secondary CTA), I can see it though:

image

@alexgibson alexgibson removed the Needs Review Awaiting code review label Feb 19, 2025
@alexgibson
Copy link
Member

Oh one other question: when is this all due to launch? Does any of it need to be behind a switch?

@wen-2018 wen-2018 force-pushed the vpn-extension-updates branch from 29176fe to bd8982f Compare February 20, 2025 16:26
@wen-2018 wen-2018 force-pushed the vpn-extension-updates branch from bd8982f to fd63197 Compare February 20, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend HTML, CSS, JS... client side stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants