Add intro and new formatting for Firefox PN and ToU #15982 #16009
+1,017
−288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- New page templates - Switch logic - New styles
stephaniehobson
force-pushed
the
terms
branch
from
7fd1650 to
361d3f6
Compare
stephaniehobson
changed the title
stephaniehobson
commented
Feb 21, 2025
|
|
||
| <div class="mzp-l-content c-back"> | ||
| <a href="{{ url('legal.index') }}"> | ||
| <span class="mzp-c-button-icon-start" aria-hidden="true"> |
There was a problem hiding this comment.
The .mzp-c-button-icon-start class requires an inline SVG to work so I get to copy/paste it 6 times.
OTOH I'm horribly misusing it here and am not against pulling this out into a new class so the icon can be an image on the page.
stephaniehobson
commented
Feb 21, 2025
|
|
||
| {% block side_nav %} | ||
| <div class="c-toc"> | ||
| <h3>{{ ftl('privacy-firefox-contents') }}</h3> |
There was a problem hiding this comment.
Blocking: This is broken.
stephaniehobson
commented
Feb 21, 2025
| {% endblock %} | ||
|
|
||
| {% block intro %} |
There was a problem hiding this comment.
Moved to an include.
stephaniehobson
commented
Feb 21, 2025
| @@ -34,6 +34,14 @@ | |||
| @import '../m24/vars/fonts'; | |||
| @import '../m24/vars/text'; | |||
|
|
|||
| // smooth scroll | |||
| html { | |||
There was a problem hiding this comment.
Making this site-wide behaviour. Pages shouldn't scroll differently from each other.
|
Opening for review but DNM because tests are broken. |
stephaniehobson
added
Do Not Merge ⚠️
Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line summary
Add intro and new formatting for Firefox Privacy Notice and Terms of Use
Significant changes and points to review
firefox-touswitch is enabledfirefox_about_rights.mdand will be replaced by a new file namedfirefox_terms_of_use.mdfirefox-touswitchIssue / Bugzilla link
Fix #15982
Testing
Affected pages:
Steps for testing:
make_preflightbefore you open your venv to make sure you have the most recent legal docsDEV=Falsein your .env file so you can test the switches/data/legal_docs/firefox_privacy_notice.md/data/legal_docs/firefox_terms_of_use.md(create the file if it does not exist)./manage.py shell_plusLegalDoc.objects.refresh()firefox-touswitch on and make sure everything is workingIf you run into trouble pmac can help you.
Fixes from #15997:
privacy/firefox.ftlfile is included only where needed (instead of on all PN pages)Missing