Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add internal utility to log audio streams to disk from real-time audio callbacks #759

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

padenot
Copy link
Collaborator

@padenot padenot commented Sep 22, 2023

I'll expose this to rust next. Example usage in test_audio_dump.cpp.

This is going to be quite useful to diagnose exactly what comes out of the system level callbacks, and compare to what is resampled and delivered at the application level, etc.

@Pehrsons

@padenot padenot force-pushed the record-audio branch 6 times, most recently from 4c7176a to 54d52a9 Compare September 25, 2023 13:20
@padenot padenot requested a review from kinetiknz September 25, 2023 15:38
@padenot
Copy link
Collaborator Author

padenot commented Sep 25, 2023

This seems to be working well from my testing.

Copy link
Collaborator

@kinetiknz kinetiknz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

minor nit: externally has a typo (externaly) in a couple of comments

@padenot padenot force-pushed the record-audio branch 2 times, most recently from ae2af63 to ea36359 Compare September 26, 2023 10:00
@padenot padenot merged commit b82e270 into master Apr 16, 2024
22 checks passed
@Pehrsons Pehrsons deleted the record-audio branch July 1, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants