Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore using thread priority facilities via function pointers #781

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

padenot
Copy link
Collaborator

@padenot padenot commented Mar 15, 2024

Turns out this can crash sometimes, and we need to be more careful. cc @yjugl.

This reverts commit 661c653.

@padenot padenot force-pushed the wasapi-no-direct-avrt branch from 056ae99 to 550f73b Compare March 15, 2024 12:38
@padenot
Copy link
Collaborator Author

padenot commented Mar 15, 2024

@padenot padenot requested a review from kinetiknz March 15, 2024 13:07
@padenot
Copy link
Collaborator Author

padenot commented Mar 15, 2024

mozilla/audio_thread_priority#27 is also related.

Copy link

@yjugl yjugl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks fine to me except perhaps how we handle the unlikely case where we would manage to load avrt.dll but not the functions within. Other remarks are more pendantic.

Copy link
Collaborator

@kinetiknz kinetiknz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ with nits fixed, thanks!

Turns out this can crash sometimes, and we need to be more careful.

This reverts commit 661c653.
@padenot padenot force-pushed the wasapi-no-direct-avrt branch from 550f73b to ce54585 Compare March 19, 2024 15:16
@padenot padenot merged commit aaffe75 into master Mar 19, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants