Invalidate timing info buffers when destorying AAudio stream. #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is to fix Fenix bug 1872354 |
kinetiknz
requested changes
Apr 29, 2024
src/cubeb_aaudio.cpp
Outdated
| @@ -1014,6 +1014,8 @@ aaudio_stream_destroy_locked(cubeb_stream * stm, lock_guard<mutex> & lock) | |||
| stm->state == stream_state::ERROR || | |||
| stm->state == stream_state::SHUTDOWN); | |||
|
|
|||
| stm->timing_info.invalidate(); | |||
There was a problem hiding this comment.
I think invalidate should happen after after ostream and istream are stopped, otherwise there's the potential for an audio callback to call compute_and_report_latency_metrics between invalidate and the rest of the stream destruction.
There was a problem hiding this comment.
Good catch! I've amended the commit and moved invalidate() to after streams stopped. Thanks for the review.
aaudio_stream_get_position() returns incorrect result because aaudio_stream_init() recycled destroyed stream where the timing_info buffers contain stale data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aaudio_stream_get_position()returns incorrect result becauseaaudio_stream_init()recycled destroyed stream where thetiming_infobuffers contain stale data.