Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opensl: Add extra asserts to help track down BMO 1913284. #795

Merged
merged 2 commits into from
Aug 17, 2024
Merged

opensl: Add extra asserts to help track down BMO 1913284. #795

merged 2 commits into from
Aug 17, 2024

Conversation

kinetiknz
Copy link
Collaborator

Add some extra asserts to help track down BMO 1913284.

Also switch from assert() to our XASSERT() wrapper so we go through Gecko's assert machinery to have crash reports annotated with the failing assert text.

@kinetiknz kinetiknz requested a review from padenot August 15, 2024 19:18
@kinetiknz kinetiknz self-assigned this Aug 15, 2024
@kinetiknz kinetiknz merged commit 8f6c9a0 into master Aug 17, 2024
30 checks passed
@kinetiknz kinetiknz deleted the opensl_asserts branch August 17, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@padenot padenot padenot approved these changes

Assignees

@kinetiknz kinetiknz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kinetiknz @padenot