Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove some unwraps and replace others by expect #2294

Merged
merged 35 commits into from
Feb 2, 2025

Merge branch 'main' into chore-unwrap-less

582f74c
Select commit
Loading
Failed to load commit list.
Merged

chore: Remove some unwraps and replace others by expect #2294

Merge branch 'main' into chore-unwrap-less
582f74c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Feb 2, 2025 in 0s

95.26% (-0.06%) compared to 63506c5

View this Pull Request on Codecov

95.26% (-0.06%) compared to 63506c5

Details

Codecov Report

Attention: Patch coverage is 90.15660% with 44 lines in your changes missing coverage. Please review.

Project coverage is 95.26%. Comparing base (63506c5) to head (582f74c).

Files with missing lines Patch % Lines
.../features/extended_connect/webtransport_session.rs 53.84% 12 Missing ⚠️
neqo-transport/src/send_stream.rs 84.90% 8 Missing ⚠️
neqo-crypto/src/agent.rs 76.47% 4 Missing ⚠️
neqo-crypto/src/agentio.rs 66.66% 4 Missing ⚠️
neqo-transport/src/connection/mod.rs 89.18% 4 Missing ⚠️
neqo-transport/src/recovery/mod.rs 84.00% 4 Missing ⚠️
neqo-qpack/src/decoder.rs 66.66% 2 Missing ⚠️
neqo-transport/src/path.rs 86.66% 2 Missing ⚠️
neqo-transport/src/tracking.rs 97.05% 2 Missing ⚠️
neqo-http3/src/connection.rs 93.75% 1 Missing ⚠️
... and 1 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2294      +/-   ##
==========================================
- Coverage   95.31%   95.26%   -0.06%     
==========================================
  Files         114      114              
  Lines       36869    36903      +34     
  Branches    36869    36903      +34     
==========================================
+ Hits        35142    35155      +13     
- Misses       1721     1742      +21     
  Partials        6        6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov