Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Try new wireshark nightly PPA #2382

Merged
merged 4 commits into from
Jan 23, 2025

Conversation

larseggert
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.31%. Comparing base (c4db9b5) to head (82ea346).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2382      +/-   ##
==========================================
+ Coverage   95.29%   95.31%   +0.02%     
==========================================
  Files         114      114              
  Lines       36850    36850              
  Branches    36850    36850              
==========================================
+ Hits        35117    35125       +8     
+ Misses       1727     1717      -10     
- Partials        6        8       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@larseggert
Copy link
Collaborator Author

Still installs 4.2.6-1. Hm.

Copy link

github-actions bot commented Jan 22, 2025

Failed Interop Tests

QUIC Interop Runner, client vs. server, differences relative to 108fb8d.

neqo-latest as client

neqo-latest as server

All results

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Unsupported Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Copy link

Benchmark results

Performance differences relative to c4db9b5.

decode 4096 bytes, mask ff: No change in performance detected.
       time:   [11.867 µs 11.908 µs 11.955 µs]
       change: [-0.1759% +0.3823% +0.9912%] (p = 0.20 > 0.05)

Found 20 outliers among 100 measurements (20.00%)
3 (3.00%) low severe
3 (3.00%) low mild
14 (14.00%) high severe

decode 1048576 bytes, mask ff: No change in performance detected.
       time:   [2.8841 ms 2.8924 ms 2.9023 ms]
       change: [-0.8841% -0.3637% +0.1500%] (p = 0.18 > 0.05)

Found 10 outliers among 100 measurements (10.00%)
1 (1.00%) low mild
1 (1.00%) high mild
8 (8.00%) high severe

decode 4096 bytes, mask 7f: No change in performance detected.
       time:   [19.761 µs 19.811 µs 19.871 µs]
       change: [-0.2752% +0.5359% +1.7331%] (p = 0.38 > 0.05)

Found 20 outliers among 100 measurements (20.00%)
5 (5.00%) low mild
1 (1.00%) high mild
14 (14.00%) high severe

decode 1048576 bytes, mask 7f: No change in performance detected.
       time:   [5.0732 ms 5.0844 ms 5.0973 ms]
       change: [-0.2968% +0.0345% +0.3548%] (p = 0.85 > 0.05)

Found 13 outliers among 100 measurements (13.00%)
13 (13.00%) high severe

decode 4096 bytes, mask 3f: No change in performance detected.
       time:   [6.8938 µs 6.9176 µs 6.9494 µs]
       change: [-0.2589% +2.5741% +9.8689%] (p = 0.39 > 0.05)

Found 11 outliers among 100 measurements (11.00%)
3 (3.00%) low mild
2 (2.00%) high mild
6 (6.00%) high severe

decode 1048576 bytes, mask 3f: No change in performance detected.
       time:   [1.4140 ms 1.4195 ms 1.4262 ms]
       change: [-0.4782% +0.0966% +0.6773%] (p = 0.75 > 0.05)

Found 9 outliers among 100 measurements (9.00%)
3 (3.00%) high mild
6 (6.00%) high severe

coalesce_acked_from_zero 1+1 entries: No change in performance detected.
       time:   [98.669 ns 99.005 ns 99.336 ns]
       change: [-0.8421% -0.4062% +0.1003%] (p = 0.09 > 0.05)

Found 11 outliers among 100 measurements (11.00%)
7 (7.00%) high mild
4 (4.00%) high severe

coalesce_acked_from_zero 3+1 entries: Change within noise threshold.
       time:   [116.21 ns 116.49 ns 116.80 ns]
       change: [-1.1710% -0.8152% -0.3507%] (p = 0.00 < 0.05)

Found 10 outliers among 100 measurements (10.00%)
2 (2.00%) low mild
1 (1.00%) high mild
7 (7.00%) high severe

coalesce_acked_from_zero 10+1 entries: Change within noise threshold.
       time:   [115.79 ns 116.00 ns 116.32 ns]
       change: [-1.9363% -1.1465% -0.5587%] (p = 0.00 < 0.05)

Found 6 outliers among 100 measurements (6.00%)
3 (3.00%) low mild
1 (1.00%) high mild
2 (2.00%) high severe

coalesce_acked_from_zero 1000+1 entries: No change in performance detected.
       time:   [97.239 ns 97.403 ns 97.592 ns]
       change: [-7.0720% -2.8576% -0.1514%] (p = 0.14 > 0.05)

Found 8 outliers among 100 measurements (8.00%)
2 (2.00%) high mild
6 (6.00%) high severe

RxStreamOrderer::inbound_frame(): Change within noise threshold.
       time:   [111.39 ms 111.45 ms 111.51 ms]
       change: [+0.0323% +0.1086% +0.1860%] (p = 0.00 < 0.05)

Found 23 outliers among 100 measurements (23.00%)
7 (7.00%) low severe
4 (4.00%) low mild
7 (7.00%) high mild
5 (5.00%) high severe

SentPackets::take_ranges: No change in performance detected.
       time:   [5.3785 µs 5.4711 µs 5.5647 µs]
       change: [-4.7139% -2.3336% +0.0576%] (p = 0.07 > 0.05)

Found 3 outliers among 100 measurements (3.00%)
3 (3.00%) high mild

transfer/pacing-false/varying-seeds: 💚 Performance has improved.
       time:   [40.816 ms 40.890 ms 40.964 ms]
       change: [-4.0159% -3.7813% -3.5501%] (p = 0.00 < 0.05)

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) low mild

transfer/pacing-true/varying-seeds: Change within noise threshold.
       time:   [41.436 ms 41.512 ms 41.585 ms]
       change: [-3.3008% -3.0670% -2.8290%] (p = 0.00 < 0.05)

Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) low mild

transfer/pacing-false/same-seed: 💚 Performance has improved.
       time:   [40.507 ms 40.572 ms 40.638 ms]
       change: [-4.2994% -4.0857% -3.8782%] (p = 0.00 < 0.05)

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild

transfer/pacing-true/same-seed: Change within noise threshold.
       time:   [41.314 ms 41.362 ms 41.410 ms]
       change: [-2.8703% -2.6757% -2.4880%] (p = 0.00 < 0.05)

Found 3 outliers among 100 measurements (3.00%)
2 (2.00%) low mild
1 (1.00%) high mild

1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: 💔 Performance has regressed.
       time:   [930.87 ms 941.22 ms 951.66 ms]
       thrpt:  [105.08 MiB/s 106.25 MiB/s 107.43 MiB/s]
change:
       time:   [+3.5598% +5.1063% +6.6048%] (p = 0.00 < 0.05)
       thrpt:  [-6.1956% -4.8582% -3.4374%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected.
       time:   [315.29 ms 317.36 ms 319.45 ms]
       thrpt:  [31.303 Kelem/s 31.510 Kelem/s 31.716 Kelem/s]
change:
       time:   [-0.9749% -0.1123% +0.8573%] (p = 0.81 > 0.05)
       thrpt:  [-0.8501% +0.1125% +0.9845%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected.
       time:   [34.119 ms 34.263 ms 34.414 ms]
       thrpt:  [29.058  elem/s 29.186  elem/s 29.310  elem/s]
change:
       time:   [-1.1384% -0.3454% +0.4403%] (p = 0.40 > 0.05)
       thrpt:  [-0.4384% +0.3466% +1.1515%]

Found 10 outliers among 100 measurements (10.00%)
7 (7.00%) low mild
1 (1.00%) high mild
2 (2.00%) high severe

1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: 💔 Performance has regressed.
       time:   [1.7370 s 1.7553 s 1.7736 s]
       thrpt:  [56.381 MiB/s 56.969 MiB/s 57.569 MiB/s]
change:
       time:   [+2.4585% +3.9366% +5.4633%] (p = 0.00 < 0.05)
       thrpt:  [-5.1803% -3.7875% -2.3995%]

Client/server transfer results

Transfer of 33554432 bytes over loopback.

Client Server CC Pacing MTU Mean [ms] Min [ms] Max [ms]
gquiche gquiche 1504 542.5 ± 41.0 505.7 600.5
neqo gquiche reno on 1504 748.0 ± 19.1 708.4 768.8
neqo gquiche reno 1504 729.9 ± 14.7 702.4 752.8
neqo gquiche cubic on 1504 753.4 ± 7.2 741.2 761.2
neqo gquiche cubic 1504 790.1 ± 80.4 725.3 984.2
msquic msquic 1504 127.4 ± 61.0 92.9 324.8
neqo msquic reno on 1504 245.9 ± 73.6 208.1 463.6
neqo msquic reno 1504 210.2 ± 13.8 197.6 246.8
neqo msquic cubic on 1504 272.4 ± 100.9 201.7 511.3
neqo msquic cubic 1504 214.7 ± 12.9 201.1 234.1
gquiche neqo reno on 1504 674.3 ± 93.6 541.6 804.8
gquiche neqo reno 1504 684.3 ± 92.1 541.8 828.2
gquiche neqo cubic on 1504 691.4 ± 84.3 575.9 820.8
gquiche neqo cubic 1504 667.5 ± 81.4 536.4 793.8
msquic neqo reno on 1504 484.4 ± 45.6 454.7 607.9
msquic neqo reno 1504 473.7 ± 8.2 462.9 484.5
msquic neqo cubic on 1504 489.7 ± 9.1 477.7 502.8
msquic neqo cubic 1504 511.0 ± 48.8 472.2 623.9
neqo neqo reno on 1504 438.8 ± 10.7 420.5 454.9
neqo neqo reno 1504 454.4 ± 11.0 434.5 473.8
neqo neqo cubic on 1504 447.5 ± 17.4 411.8 476.7
neqo neqo cubic 1504 473.1 ± 12.4 454.6 495.3

⬇️ Download logs

@larseggert
Copy link
Collaborator Author

This now installs 4.5. Looking into why the CM test fails.

@larseggert larseggert merged commit d62557f into mozilla:main Jan 23, 2025
62 of 67 checks passed
@larseggert larseggert deleted the ci-qns-wireshark-nightly branch January 24, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants