chore: Invert SNI slicing option to --no-sni-slicing
#2388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be consistent with other options, and so we can actually turn it off. Also add it to `test.sh`, so that the `tshark` parsing works.
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
mxinden
reviewed
Jan 24, 2025
mxinden
approved these changes
Jan 24, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2388 +/- ##
==========================================
- Coverage 95.29% 95.29% -0.01%
==========================================
Files 114 114
Lines 36868 36868
Branches 36868 36868
==========================================
- Hits 35135 35134 -1
- Misses 1727 1728 +1
Partials 6 6 ☔ View full report in Codecov by Sentry. |
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to 108fb8d. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Benchmark resultsPerformance differences relative to 7315d10. decode 4096 bytes, mask ff: No change in performance detected. time: [11.831 µs 11.860 µs 11.896 µs]
change: [-0.1949% +0.0603% +0.3429%] (p = 0.67 > 0.05)
decode 1048576 bytes, mask ff: No change in performance detected. time: [2.8848 ms 2.8941 ms 2.9051 ms]
change: [-0.6739% -0.1689% +0.3309%] (p = 0.52 > 0.05)
decode 4096 bytes, mask 7f: No change in performance detected. time: [19.800 µs 19.859 µs 19.921 µs]
change: [-0.3810% +0.0187% +0.3966%] (p = 0.93 > 0.05)
decode 1048576 bytes, mask 7f: No change in performance detected. time: [5.0691 ms 5.0800 ms 5.0915 ms]
change: [-0.5812% -0.2170% +0.1414%] (p = 0.25 > 0.05)
decode 4096 bytes, mask 3f: No change in performance detected. time: [6.8892 µs 6.9071 µs 6.9321 µs]
change: [-0.9566% -0.3188% +0.3568%] (p = 0.37 > 0.05)
decode 1048576 bytes, mask 3f: No change in performance detected. time: [1.4141 ms 1.4196 ms 1.4264 ms]
change: [-0.4978% +0.0864% +0.6727%] (p = 0.80 > 0.05)
coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [99.398 ns 99.753 ns 100.12 ns]
change: [-0.0901% +0.3792% +0.8124%] (p = 0.11 > 0.05)
coalesce_acked_from_zero 3+1 entries: Change within noise threshold. time: [117.72 ns 118.11 ns 118.52 ns]
change: [+0.2721% +0.7744% +1.2895%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [117.11 ns 117.50 ns 117.99 ns]
change: [-0.1549% +0.5349% +1.2525%] (p = 0.14 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [98.345 ns 98.498 ns 98.677 ns]
change: [-0.6442% +0.3296% +1.2938%] (p = 0.52 > 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [111.57 ms 111.62 ms 111.68 ms]
change: [+0.1590% +0.2226% +0.2920%] (p = 0.00 < 0.05)
SentPackets::take_ranges: No change in performance detected. time: [5.4025 µs 5.4884 µs 5.5771 µs]
change: [-2.0758% +0.5011% +3.4991%] (p = 0.73 > 0.05)
transfer/pacing-false/varying-seeds: Change within noise threshold. time: [41.513 ms 41.601 ms 41.690 ms]
change: [+1.6395% +1.9150% +2.2084%] (p = 0.00 < 0.05)
transfer/pacing-true/varying-seeds: Change within noise threshold. time: [41.702 ms 41.771 ms 41.841 ms]
change: [+1.4315% +1.6758% +1.9180%] (p = 0.00 < 0.05)
transfer/pacing-false/same-seed: Change within noise threshold. time: [41.631 ms 41.687 ms 41.744 ms]
change: [+2.4807% +2.6802% +2.8906%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed: Change within noise threshold. time: [41.979 ms 42.045 ms 42.110 ms]
change: [+2.7296% +2.9409% +3.1584%] (p = 0.00 < 0.05)
1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: Change within noise threshold. time: [876.55 ms 886.65 ms 897.16 ms]
thrpt: [111.46 MiB/s 112.78 MiB/s 114.08 MiB/s]
change:
time: [-3.3446% -1.7569% -0.1784%] (p = 0.04 < 0.05)
thrpt: [+0.1787% +1.7883% +3.4603%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected. time: [315.79 ms 318.18 ms 320.61 ms]
thrpt: [31.190 Kelem/s 31.429 Kelem/s 31.667 Kelem/s]
change:
time: [-0.7557% +0.2857% +1.3314%] (p = 0.58 > 0.05)
thrpt: [-1.3139% -0.2848% +0.7615%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected. time: [34.245 ms 34.395 ms 34.562 ms]
thrpt: [28.933 elem/s 29.074 elem/s 29.201 elem/s]
change:
time: [-0.7071% +0.0547% +0.8183%] (p = 0.90 > 0.05)
thrpt: [-0.8117% -0.0547% +0.7122%]
1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: 💔 Performance has regressed. time: [1.7461 s 1.7633 s 1.7805 s]
thrpt: [56.164 MiB/s 56.713 MiB/s 57.271 MiB/s]
change:
time: [+1.2137% +2.5193% +3.8662%] (p = 0.00 < 0.05)
thrpt: [-3.7223% -2.4574% -1.1992%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be consistent with other options, and so we can actually turn it off.
Also add it to
test.sh, so that thetsharkparsing works.