Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message property in Mpdf.php #2043

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Conversation

cebe
Copy link

@cebe cebe commented Aug 15, 2024

Exception thrown on invalid UTF-8 input asks about property in_charset. The actual property name is charset_in:

https://github.com/cebe/mpdf/blob/dfb5346e2e7ffdb4b0f6d588e94629ad52fb3466/src/Mpdf.php#L529

Exception thrown on invalid UTF-8 input asks about property `in_charset`. The actual property name is `charset_in`.
@cebe cebe changed the title Fix error message property in in Mpdf.php Fix error message property in Mpdf.php Aug 15, 2024
@finwe
Copy link
Member

finwe commented Aug 16, 2024

Thanks for a PR. Please add a unit test covering this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants