Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lth demo #30695

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

lth demo #30695

wants to merge 5 commits into from

Conversation

lo-th
Copy link

@lo-th lo-th commented Mar 9, 2025

Description

new demo for three js
webgl_animation_walk
webgl_random_uv
webgl_watch

update for webgl_gpgpu_water.html

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@Mugen87
Copy link
Collaborator

Mugen87 commented Mar 9, 2025

Thank your for your contributions but I'm afraid none of the example demonstrate a library feature that has not been demonstrated already. We also want to limit the number of examples, especially the ones using WebGLRenderer, because a lot of new examples for WebGPURenderer and TSL have been added.

Besides, we do not want to add any more examples using Material.onBeforeCompile() since the shader patching approach turned out to be fragile and error prone.

It's probably best if you share your demos at the forum in the Resource category.

@lo-th
Copy link
Author

lo-th commented Mar 9, 2025

is a mrdoob request but ok ...

@Mugen87
Copy link
Collaborator

Mugen87 commented Mar 9, 2025

Sure, I won't close the PR. It's up to @mrdoob to decide.

I bet it took quite some time to develop the examples so I can understand it's disappointing. But we have guidelines and it's important to honor them. Next time, it's maybe better to file an issue first and clarify if your planned demos can be added or not.

@lo-th
Copy link
Author

lo-th commented Mar 9, 2025

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants