Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIPChanges to yaml files, deployment bicep script, and readme file. #247

Open
wants to merge 44 commits into
base: main
Choose a base branch
from

Conversation

francisnazareth
Copy link
Contributor

@francisnazareth francisnazareth commented Jan 31, 2025

azuredeploy.bicep

  • Removing use of service principal (client ID and client secret) for AKS cluster creation. (managed identity is preferred)
  • Removing Kubernetes version parameter (as default version is used)
  • Removing storage account creation (as this storage account is not used by any of the microservices).
  • Adding resource group contributor role assignment to the managed identity
  • Removing Log analytics workspace creation (as a log analytics workspace is already created by the fabrikam workload bicep script).
  • Changing the script to take in the existing log analytics workspace's resource ID as a parameter and create the AKS cluster using the log analytics workspace resource ID.

charts/package/template/package-deploy.yaml

The package microservice needs App insights connection string. Hence adding this connection string as a secret in the deployment yaml file.

charts/package/templates/package-secret-provider.yaml
adding a new key and value for application insights connection string (this will be used in the deployment yaml file)

Readme file:
Changes for readability, document structure, and ease of deployment (as the previous documentation was too complex).

@ckittel

@francisnazareth francisnazareth changed the title [WIPChanges to yaml files, deployment bicep script, and [WIPChanges to yaml files, deployment bicep script, and readme file. Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant