New feature: Support hidden input (for passwords and the like). #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Controlled by internal global flag variable "is_hidden". Added two new accessor functions to set and retrieve the flag's state. (Avoided changing the signature of linenoise()). Activating hidden input - Causes all entered characters to be echoed back as '*'. - Disables navigating and searching the history. - Disables line completion. - All other editing commands are left active.
|
Rebased code pushed |
|
I still need to convince myself that there is enough value-add in this feature. Since history, and to a lesser extent editing, don't make sense for hidden input I'm not certain there is enough value here for it to be part of linenoise. I will think about it a bit more though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Controlled by internal global flag variable "is_hidden".
Added two new accessor functions to set and retrieve the flag's state.
(Avoided changing the signature of linenoise()).
Activating hidden input