[Autocomplete] Fix when onHighlightChange is called
#45438
+25
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeeshanTamboli
added
bug 🐛
…d-when-listbox-opens
Netlify deploy previewhttps://deploy-preview-45438--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43213
The
onHighlightChangeprop, introduced in #20691, did not correctly determine when it should be triggered.This PR:
onHighlightChangewas incorrectly triggered when the listbox opened.defaultValue: When adefaultValueis provided, the highlighted option remains the same when opening the listbox, soonHighlightChangeshould not be called. The existing test case for this behavior has been removed, as it does not align with the expected logic. Example: https://stackblitz.com/edit/stackblitz-starters-bocrcrmconHighlightChangewhen there is a mouse, keyboard or touch interaction over the options.Notice that the
eventparameter wasundefined, further indicating incorrect handling.I have also modified the test cases.
Before: https://stackblitz.com/edit/react-d4b5ls?file=Demo.tsx
After: https://codesandbox.io/p/sandbox/material-ui-cra-ts-forked-mpm2ft