[DataGrid] Make base data source available in the Community plan #16359
+1,201
−836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MBilalShafi
added
component: data grid
|
Deploy preview: https://deploy-preview-16359--material-ui-x.netlify.app/ Updated pages: |
5 tasks
github-actions
bot
added
the
PR: out-of-date
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
removed
the
PR: out-of-date
github-actions
bot
added
the
PR: out-of-date
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
removed
the
PR: out-of-date
MBilalShafi
changed the title
romgrk
reviewed
Feb 4, 2025
Comment on lines
-31
to
+32
| const initialStateWithPagination = React.useMemo( | ||
| const initialState = React.useMemo( |
There was a problem hiding this comment.
"Pagination" was removed from the name but is still present in the object's value, should it be removed?
romgrk
reviewed
Feb 4, 2025
| paginationModel, | ||
| sortModel, | ||
| filterModel, | ||
| ...computeStartEnd(paginationModel), |
There was a problem hiding this comment.
It doesn't feel like it needs to be in a separate function.
romgrk
reviewed
Feb 4, 2025
| @@ -26,6 +26,7 @@ import { HeightEntry } from '../../features/rows/gridRowsMetaInterfaces'; | |||
| export type GridPipeProcessorGroup = keyof GridPipeProcessingLookup; | |||
|
|
|||
| export interface GridPipeProcessingLookup { | |||
| clearDataSourceState: { value: null }; | |||
There was a problem hiding this comment.
Tbh I don't love pipe processors, I feel like they make the flow a bit hard to understand. Is there a way we could use an alternative? Could the newer grid config context be used instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #15373