[data grid] Fix choppy overlay resizing #16367
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-16367--material-ui-x.netlify.app/ |
zannager
added
the
component: data grid
KenanYusuf
approved these changes
Jan 29, 2025
Co-authored-by: Kenan Yusuf <[email protected]> Signed-off-by: Lauri <[email protected]>
Co-authored-by: Kenan Yusuf <[email protected]> Signed-off-by: Lauri <[email protected]>
romgrk
reviewed
Jan 29, 2025
Comment on lines
+194
to
+200
| height: Math.max( | ||
| 0, | ||
| viewportOuterSize.height - | ||
| topContainerHeight - | ||
| bottomContainerHeight - | ||
| (hasScrollX ? scrollbarSize : 0), | ||
| ), |
There was a problem hiding this comment.
For this PR and the other one, we need to document (breaking) changes to viewportInnerSize in https://github.com/mui/mui-x/blob/master/docs/data/migration/migration-data-grid-v7/migration-data-grid-v7.md
There was a problem hiding this comment.
is the plan to keep autoHeight around for the v8, given that it's already deprecated in v7?
There was a problem hiding this comment.
It's not confirmed, but it's likely autoHeight will still be available in v8.
There was a problem hiding this comment.
We might undeprecate that prop if the new alternative's issues can't be worked out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes choppy overlay resizing.
Currently, overlays depend on widths passed as style based on DOM measurements. This is not necessary though, and since updating dimensions is throttled, it can make overlays appear choppy when the viewport is resized.
Normally, this is not a problem, but with overlays it is:
Best demo to test it on:
https://next.mui.com/x/react-data-grid/overlays/#custom-component
You see the centred content moving with a delay, and especially at breakpoints (but also when resizing fast or with an animation) you get a flash of the underlying content.
The issue:
before-choppy.mp4
After:
after-no-chop.mp4