[TreeView]: allow reordering item to bottom #16384
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyash97
commented
Jan 29, 2025
| }, | ||
| // For the last element allow reordering to the bottom | ||
| 'reorder-below': | ||
| !targetItemMeta.expandable || targetItemIndex + 1 === totalItems |
There was a problem hiding this comment.
As I am looking into the diff, I feel the condition should be only applicable when parentId is null
zannager
added
the
component: tree view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16171
Currently, we weren't allowing the items to be reordered to the bottom of the list, I added a condition to
reorder-belowin case we reach the end of the list. Attaching a video in order to show the working of the current fix.Mui-X.reordering.mov