-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[license] Updated the LicenseInfo
class with 2 additional checks
#16404
Open
michelengelen
wants to merge
6
commits into
mui:master
Choose a base branch
from
michelengelen:license/update-licensInfo-class
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+44
−0
Open
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
fab9d2e
updated the LicenseInfo class and added 2 new errors for setLicenseKe…
michelengelen 4395a7f
Merge branch 'master' into license/update-licensInfo-class
michelengelen 28644f4
Apply suggestions from code review
michelengelen 2c09097
Update packages/x-license/src/utils/licenseErrorMessageUtils.ts
michelengelen 18eb656
Update packages/x-license/src/utils/licenseErrorMessageUtils.ts
michelengelen f23eba0
Merge branch 'master' into license/update-licensInfo-class
michelengelen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -17,6 +17,10 @@ ponyfillGlobal.__MUI_LICENSE_INFO__ = ponyfillGlobal.__MUI_LICENSE_INFO__ || { | |||||||||||||||||||||||
}; | ||||||||||||||||||||||||
|
||||||||||||||||||||||||
export class LicenseInfo { | ||||||||||||||||||||||||
private static hasSetLicenseKeyRun: boolean = false; | ||||||||||||||||||||||||
|
||||||||||||||||||||||||
private static isLicenseKeySet: boolean = false; | ||||||||||||||||||||||||
|
||||||||||||||||||||||||
private static getLicenseInfo() { | ||||||||||||||||||||||||
// eslint-disable-next-line no-underscore-dangle | ||||||||||||||||||||||||
return ponyfillGlobal.__MUI_LICENSE_INFO__; | ||||||||||||||||||||||||
|
@@ -29,5 +33,15 @@ export class LicenseInfo { | |||||||||||||||||||||||
public static setLicenseKey(key: string) { | ||||||||||||||||||||||||
const licenseInfo = LicenseInfo.getLicenseInfo(); | ||||||||||||||||||||||||
licenseInfo.key = key; | ||||||||||||||||||||||||
LicenseInfo.isLicenseKeySet = !!key; | ||||||||||||||||||||||||
LicenseInfo.hasSetLicenseKeyRun = true; | ||||||||||||||||||||||||
} | ||||||||||||||||||||||||
|
||||||||||||||||||||||||
public static getIsLicenseKeySet(): boolean { | ||||||||||||||||||||||||
return LicenseInfo.isLicenseKeySet; | ||||||||||||||||||||||||
} | ||||||||||||||||||||||||
|
||||||||||||||||||||||||
public static getHasSetLicenseKeyRun(): boolean { | ||||||||||||||||||||||||
return LicenseInfo.hasSetLicenseKeyRun; | ||||||||||||||||||||||||
Comment on lines
+36
to
+45
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We could do this with less code, no?
Suggested change
and then ponyfillGlobal.__MUI_LICENSE_INFO__ = ponyfillGlobal.__MUI_LICENSE_INFO__ || {
- key: undefined,
+ key: 'default',
}; |
||||||||||||||||||||||||
} | ||||||||||||||||||||||||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error looks out of place, I got the impression that
LICENSE_STATUS
is meant for this.