Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts] Introduce the radar chart #16406

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

alexfauquette
Copy link
Member

@alexfauquette alexfauquette commented Jan 30, 2025

This PR is a rough first version of the Radar chart #7925. Lots of features are missing.

The idea is to validate the data structure, and it's mapping to a rotation/radius scale system. If ok, we can merge this one and add features in distinct PR such that we keep them small enough to be relevant (I don't expect someone to read 200 files with 10 different features and spot any bug or room for improvement)

Main idea

The polar plugin introduce the support of rotatio/radius axes that work similarly to the x/y axes

The radar don't expose directly those axies. It uses an intermediate metrics to make sure the radar has only one rotation axis with scale point, and one radius axis per metric.

Then we have one component per item rendered (grid, area, and marks)

Features

  • Polar coordinate
  • Map series config to rendering
  • Correct margins
  • Correct light/dark colors
  • Axes labels
  • Variants of axes shape (rounded one)
  • Interaction
  • Highlight
  • Tooltip
  • Defining the composition customization (opportunity to experiment with base-ui DX)
  • ARIA attributes?

Preview: https://deploy-preview-16406--material-ui-x.netlify.app/x/react-charts/radar/

@alexfauquette alexfauquette added new feature New feature or request component: charts This is the name of the generic UI component, not the React module! labels Jan 30, 2025
@mui-bot
Copy link

mui-bot commented Jan 30, 2025

Deploy preview: https://deploy-preview-16406--material-ui-x.netlify.app/

Updated pages:

Generated by 🚫 dangerJS against 8cf53e3

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 31, 2025
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 31, 2025
@alexfauquette alexfauquette marked this pull request as ready for review January 31, 2025 11:11
Copy link

codspeed-hq bot commented Jan 31, 2025

CodSpeed Performance Report

Merging #16406 will not alter performance

Comparing alexfauquette:radar-chart (8cf53e3) with master (b252b9a)

Summary

✅ 6 untouched benchmarks

@alexfauquette alexfauquette marked this pull request as draft January 31, 2025 15:28
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 4, 2025
Copy link

github-actions bot commented Feb 4, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 4, 2025
@alexfauquette alexfauquette marked this pull request as ready for review February 4, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: charts This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants